Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Postgres with separate env variables #108

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

jesper7
Copy link
Contributor

@jesper7 jesper7 commented Jun 16, 2023

Some users may want to use Postgres variables with certain symbols such as @ in them. Unfortunately, this breaks the Postgres connection URI, as certain symbols get treated as delimiters.

To work around it, I've refactored the values and environment passed to Studio so that we always use separate environment variables for the Postgres configuration. This means that the previous fields:

  • global.postgres.databaseUrl
  • global.postgres.databaseUser
  • global.postgres.databasePassword

are now deprecated.

@jesper7 jesper7 added the enhancement New feature or request label Jun 16, 2023
@jesper7 jesper7 requested a review from mjasion June 16, 2023 17:31
@jesper7 jesper7 self-assigned this Jun 16, 2023
@jesper7 jesper7 marked this pull request as draft June 16, 2023 17:31
@jesper7 jesper7 requested review from ilongin and a team June 16, 2023 17:40
amritghimire
amritghimire previously approved these changes Jun 19, 2023
@mjasion mjasion marked this pull request as ready for review June 20, 2023 13:33
@mjasion
Copy link
Contributor

mjasion commented Jun 21, 2023

I bumped the Studio version to v2.4.0

Studio v2 Bumped the django version to v4
@mjasion mjasion removed the request for review from ilongin June 21, 2023 13:18
@mjasion mjasion merged commit 0317339 into main Jun 21, 2023
@mjasion mjasion deleted the pg-separate-env-vars branch June 21, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants