Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPI: narrower banner #8

Merged
merged 3 commits into from
Mar 15, 2022
Merged

TPI: narrower banner #8

merged 3 commits into from
Mar 15, 2022

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Mar 10, 2022 •
edited
Loading

For iterative/terraform-provider-iterative#433

Mainly to reduce height.

Before

After

@casperdcl casperdcl self-assigned this Mar 10, 2022
@casperdcl casperdcl requested review from a team and dmpetrov March 10, 2022 22:00
@casperdcl casperdcl mentioned this pull request Mar 10, 2022
Merged
4 tasks
0x2b3bfa0
0x2b3bfa0 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the design, but the new version is definitely more compact and better than a placeholder.

@0x2b3bfa0
Copy link
Member

SVG

tpi

@shcheklein
Copy link
Member

Should we use https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/ ?

Also, we can ask @yalozhkin and @arcticbear to improve it if we have some ideas.

@shcheklein
Copy link
Member

Screen Shot 2022-03-10 at 2 41 36 PM

This is how it looks like for me (font is not readable).

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Mar 10, 2022 •
edited
Loading

I didn't want to fix this until the layout was finished because it makes modifications more difficult, but here it is.

Border (thick)

157766255-8447e0f2-03b1-492e-b2e8-6af9a8a2d6a2

Border (thin)

157769874-640cd21b-8298-4c67-8338-77f385328bc6

Dark/light mode

157766255-8447e0f2-03b1-492e-b2e8-6af9a8a2d6a2
157766255-8447e0f2-03b1-492e-b2e8-6af9a8a2d6a2

@0x2b3bfa0

This comment was marked as off-topic.

Sign in to view
@0x2b3bfa0

This comment was marked as resolved.

Sign in to view
@0x2b3bfa0

This comment was marked as resolved.

Sign in to view
@0x2b3bfa0

This comment was marked as resolved.

Sign in to view
@yalozhkin
Copy link
Contributor

@0x2b3bfa0 where can I get the original Terraform logo SVG? When I try to open the logo from the thread, it looks broken.

@0x2b3bfa0
Copy link
Member

https://www.hashicorp.com/brand#terraform

@casperdcl casperdcl mentioned this pull request Mar 11, 2022
Open
21 tasks
@yalozhkin
Copy link
Contributor

terraform-iterative

casperdcl
casperdcl commented Mar 14, 2022
View reviewed changes
img/cml/banner-tpi.svg Outdated Show resolved Hide resolved
@casperdcl casperdcl merged commit 89536d5 into main Mar 15, 2022
@casperdcl casperdcl deleted the tpi-banner branch March 15, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticbear arcticbear arcticbear left review comments

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@dmpetrov dmpetrov Awaiting requested review from dmpetrov

Assignees

@casperdcl casperdcl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@casperdcl @0x2b3bfa0 @shcheklein @yalozhkin @arcticbear