Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor — GCP #156

Merged
merged 9 commits into from
Jul 13, 2021
Merged

Vendor — GCP #156

merged 9 commits into from
Jul 13, 2021

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jul 4, 2021 •
edited
Loading

Google Cloud

How to test

  1. Create a project, a new service account, and its corresponding JSON key file.
  2. Export the credentials with export GOOGLE_APPLICATION_CREDENTIALS_DATA="$(cat /path/to/service-account.json)"
  3. Build and test the provider manually. 😱

Low priority pending tasks

Note: this pull request is a follow-up of the boilerplate on #145.

@0x2b3bfa0 0x2b3bfa0 added cloud-new New cloud support request cloud-gcp Google Cloud labels Jul 4, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jul 4, 2021
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jul 4, 2021
Merged
@0x2b3bfa0 0x2b3bfa0 changed the title Gcp vendor GCP vendor Jul 4, 2021
@0x2b3bfa0 0x2b3bfa0 linked an issue Jul 4, 2021 that may be closed by this pull request
Vendor - GCP #64
Closed
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review July 4, 2021 03:07
@0x2b3bfa0 0x2b3bfa0 changed the title GCP vendor Vendor — GCP Jul 4, 2021
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jul 4, 2021
Merged
@0x2b3bfa0 0x2b3bfa0 force-pushed the gcp-vendor branch 2 times, most recently from d23ffb2 to 29aafe7 Compare July 4, 2021 15:45
@restyled-io restyled-io bot mentioned this pull request Jul 4, 2021
Closed
@0x2b3bfa0 0x2b3bfa0 force-pushed the gcp-vendor branch 2 times, most recently from 34190e6 to ce1bfb5 Compare July 6, 2021 15:37
@DavidGOrtega

This comment has been minimized.

Sign in to view
@DavidGOrtega

This comment has been minimized.

Sign in to view
@DavidGOrtega

This comment has been minimized.

Sign in to view
@0x2b3bfa0 0x2b3bfa0 requested a review from DavidGOrtega July 12, 2021 18:32
@0x2b3bfa0
Copy link
Member Author

Nice catches on c4bd9f3 and af544a2 🎉

@0x2b3bfa0
Copy link
Member Author

I've solved the remaining lapsus and marked your comments as outdated, as I can't use resolved on comments that don't belong to a review. Feel free to check them again.

@DavidGOrtega DavidGOrtega merged commit 0333ac2 into master Jul 13, 2021
@DavidGOrtega DavidGOrtega deleted the gcp-vendor branch July 13, 2021 16:42
@casperdcl casperdcl mentioned this pull request Jul 28, 2021
Closed
4 tasks
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega left review comments

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-gcp Google Cloud cloud-new New cloud support request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vendor - GCP
2 participants
@0x2b3bfa0 @DavidGOrtega