Allow custom images on iterative_cml_runner resource

[0x2b3bfa0]

Could close #231 if merged

[dacbd]

Are there non-systemd images that could be selected(are there any popular non-systemd distros anymore)? That would definitely break, or consider that too much of archaic possibility to be concerned about?

[0x2b3bfa0]

Are there non-systemd images that could be selected [...] ?

Of course! Custom images may use any other init system.

[...] are there any popular non-systemd distros anymore.

Alpine, which uses OpenRC. 🤷🏼 Although its popularity for containers is — by far — greater than for virtual machines.

That would definitely break, or consider that too much of archaic possibility to be concerned about?

We consider systemd as a hard dependency. 🙉 It's included on all the popular virtual machine images, so relying on it is relatively safe.

[dacbd]

Are there non-systemd images that could be selected [...] ?

Of course! Custom images may use any other init system.

Yeah I realized this was a silly question 🦒

[0x2b3bfa0]

Not really; that's an excellent addition to the documentation. I believe that users with custom images will also wonder what the minimum requirements are.

[casperdcl]

users with custom images will also wonder what the minimum requirements are.

we could add another FROM line midway through https://github.com/iterative/cml/blob/master/Dockerfile to distinguish optional deps from essential ones?

[0x2b3bfa0]

Container images only require tar and coreutils. This is about machine images.

[casperdcl]

don't we need terraform, node & cml too?

[0x2b3bfa0]

Yes, for the iterative_cml_runner resource

[DavidGOrtega]

Im missing a check of terraform in the setup script to fail in case its not present.
If not the runner resource is going to destroy itself after timeout without an apparent reason.

[0x2b3bfa0]

Despite not being set as computed in the schema, the startup_script argument is being overridden always by the runner installation script.

terraform-provider-iterative/iterative/resource_runner.go

Lines 149 to 155 in 550c698

	"startup_script": &schema.Schema{
	Type: schema.TypeString,
	ForceNew: true,
	Optional: true,
	Default: "",
	Sensitive: true,
	},

terraform-provider-iterative/iterative/resource_runner.go

Line 201 in 550c698

d.Set("startup_script", startupScript)

While the current startup_script behavior might not be as sensible as one could desire, it doesn't seem to be related to this pull request. 🤔

[DavidGOrtega]

Despite not being set as computed in the schema, the startup_script argument is being overridden always by the runner installation script.

Thats weird. startup_script argument should be executed within the runner's script

{- if not .container}}
{{- if .setup}}{{.setup}}{{- end}}
sudo npm config set user 0 && sudo npm install --global @dvcorg/cml
{{- end}}

{{- if .runner_startup_script}}
{{.runner_startup_script}}
{{- end}}

{{- if not .container}}
sudo tee /usr/bin/cml.sh << 'EOF'
#!/bin/sh
{{- end}}

[0x2b3bfa0]

@iterative/cml, can we merge this?