-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make smoke tests more lightweight #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stretch goal: make also spot instance testing optional
Spot: common.SpotEnabled, |
Use single workflow. Use env var to toggle gpu test. Add parameter for using spot instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Daniel Barnes <dabarnes2b@gmail.com>
Note that terraform-provider-iterative/.github/workflows/smoke.yml Lines 106 to 112 in d587a7f
See the collapsible at https://registry.terraform.io/providers/iterative/iterative/latest/docs/guides/testing-kubernetes#creating-a-test-cluster for more information: terraform-provider-iterative/docs/guides/testing-kubernetes.md Lines 46 to 50 in 89ff041
|
Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome to me! 🎉
Currently smoke tests call tpi to provision machines with GPUs. This often runs into resource quotas.
The proposal runs PR tests provisioning smaller (m) machines and a test to provision machines with GPUS is
run on a fixed daily schedule on master.