Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple waiting feedback for leo #711

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Simple waiting feedback for leo #711

merged 3 commits into from
Nov 8, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Nov 8, 2022

adds some simple feedback for when users run leo read --follow right after a leo create and there aren't any logs yet.

dacbd added 2 commits November 7, 2022 15:34
for --follow while still setting up the instance
@dacbd dacbd requested a review from a team November 8, 2022 00:47
@dacbd dacbd self-assigned this Nov 8, 2022
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please print to os.Stderr

@tasdomas
Copy link
Contributor

tasdomas commented Nov 8, 2022

Please print to os.Stderr

Is that really necessary? In this case the output is purely for UX, stdout is perfectly valid.

Granted, leo could use a quiet mode that's more automation friendly, but we've got more pressing issues

@0x2b3bfa0
Copy link
Member

Currently leo read only outputs script logs to standard output, and all the other user-oriented messages to standard error. While we still don't provide any stability guarantees, it would be nice to stick to that principle.

@0x2b3bfa0 0x2b3bfa0 merged commit f84401c into master Nov 8, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the follow-progess branch November 8, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants