-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identifiers with configurable prefixes #727
Conversation
Also useful for #726 and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why enforce the 3 character length requirement? Alternatively, can we just have some const
prefix values to choose from? E.g.
type prefix string
const (
prefixTPI prefix = "tpi"
prefixLEO prefix = "leo"
prefixCML prefix = "cml"
)
To avoid having to recalculate the lengths of other fields in the identifier. |
I don't see a big difference - keeping it a simple string seems slightly more extendable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my mind, the “flexibility” provided by acepting arbitrary prefixes is a bit of a footcannon, but... 🤷🏼♂️
This is needed to be able to differentiate between tasks allocated using leo server and tpi/leo cli.