Add createTreeView wrapper (#703)

* move params and metrics tree to mixed type

* remove get param or metric methods where possible

* rework tree data type

* improve test

* improve test variable names

* add create tree view wrapper

Co-authored-by: rogermparent <rogermparent@gmail.com>

extension/src/experiments/model/filterBy/tree.ts

@@ -6,12 +6,12 @@ import {
   TreeDataProvider,
   TreeItem,
   TreeItemCollapsibleState,
-  Uri,
-  window
+  Uri
 } from 'vscode'
 import { getFilterId } from '.'
 import { Experiments } from '../..'
 import { definedAndNonEmpty, flatten } from '../../../util/array'
+import { createTreeView } from '../../../vscode/tree'
 
 type FilterItem = {
   description: string
@@ -33,14 +33,7 @@ export class ExperimentsFilterByTree
     this.onDidChangeTreeData = experiments.experimentsChanged.event
 
     this.dispose.track(
-      window.createTreeView<string | FilterItem>(
-        'dvc.views.experimentsFilterByTree',
-        {
-          canSelectMany: true,
-          showCollapseAll: true,
-          treeDataProvider: this
-        }
-      )
+      createTreeView<FilterItem>('dvc.views.experimentsFilterByTree', this)
     )
 
     this.experiments = experiments

extension/src/experiments/paramsAndMetrics/tree.ts

@@ -7,13 +7,13 @@ import {
   TreeItem,
   TreeItemCollapsibleState,
   TreeView,
-  Uri,
-  window
+  Uri
 } from 'vscode'
 import { Status } from './model'
 import { Experiments } from '..'
 import { Resource, ResourceLocator } from '../../resourceLocator'
 import { definedAndNonEmpty, flatten } from '../../util/array'
+import { createTreeView } from '../../vscode/tree'
 
 type ParamsAndMetricsItem = {
   description: string | undefined
@@ -41,13 +41,9 @@ export class ExperimentsParamsAndMetricsTree
     this.onDidChangeTreeData = experiments.paramsOrMetricsChanged.event
 
     this.view = this.dispose.track(
-      window.createTreeView<string | ParamsAndMetricsItem>(
+      createTreeView<ParamsAndMetricsItem>(
         'dvc.views.experimentsParamsAndMetricsTree',
-        {
-          canSelectMany: true,
-          showCollapseAll: true,
-          treeDataProvider: this
-        }
+        this
       )
     )
 

extension/src/vscode/tree.ts

@@ -0,0 +1,11 @@
+import { TreeDataProvider, TreeView, window } from 'vscode'
+
+export const createTreeView = <T>(
+  name: string,
+  treeDataProvider: TreeDataProvider<string | T>
+): TreeView<string | T> =>
+  window.createTreeView<string | T>(name, {
+    canSelectMany: true,
+    showCollapseAll: true,
+    treeDataProvider
+  })