Skip to content

Commit

Permalink
Remove newlines and set width of panels
Browse files Browse the repository at this point in the history
  • Loading branch information
mattseddon committed May 30, 2023
1 parent 6bb685c commit 43b1697
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 17 deletions.
16 changes: 7 additions & 9 deletions webview/src/setup/components/remotes/AmazonS3.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,18 @@ export const AmazonS3 = () => (
<a href="https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-quickstart.html">
AWS CLI config
</a>
.{'\n'}This reads the default AWS credentials file (if available) or env
vars.
</p>
<p>
<InfoText>
The AWS user needs the following permissions:{'\n'} s3:ListBucket,
s3:GetObject, s3:PutObject, s3:DeleteObject.
</InfoText>
. This reads the default AWS credentials file (if available) or env vars.
</p>

<InfoText>
The AWS user needs the following permissions: s3:ListBucket, s3:GetObject,
s3:PutObject, s3:DeleteObject.
</InfoText>
<CloudVersioning>
<a href="https://docs.aws.amazon.com/AmazonS3/latest/userguide/Versioning.html">
S3 versioning
</a>{' '}
enabled on the bucket.{'\n'}
enabled on the bucket.
</CloudVersioning>
<CustomAuth href="https://dvc.org/doc/user-guide/data-management/remote-storage/amazon-s3#custom-authentication" />
</div>
Expand Down
2 changes: 1 addition & 1 deletion webview/src/setup/components/remotes/AzureBlobStorage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const AzureBlobStorage = () => (
<a href="https://learn.microsoft.com/en-us/azure/storage/blobs/versioning-overview">
Blob versioning
</a>{' '}
enabled on the storage account{'\n'}and container.{' '}
enabled on the storage account and container.
</CloudVersioning>
</div>
)
3 changes: 1 addition & 2 deletions webview/src/setup/components/remotes/CloudVersioning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import { CodeBlock } from '../shared/CodeBlock'
export const CloudVersioning: React.FC<PropsWithChildren> = ({ children }) => (
<>
<InfoText>
<CloudVersioningLink /> requires {children}
To enable run:
<CloudVersioningLink /> requires <span>{children}</span> To enable run:
</InfoText>
<CodeBlock language="bash">
dvc remote modify myremote version_aware true
Expand Down
7 changes: 3 additions & 4 deletions webview/src/setup/components/remotes/GoogleCloudStorage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,22 @@ export const GoogleCloudStorage: React.FC = () => (
<a href="https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-quickstart.html">
glcoud CLI authorization
</a>
.{'\n'}This reads the default GCP key file.
. This reads the default GCP key file.
</p>
<p>
<Icon icon={Warning} width={16} height={16} className={styles.warnIcon} />{' '}
Make sure to run{' '}
<a href="https://cloud.google.com/sdk/gcloud/reference/auth/application-default/login">
gcloud auth application-default login
</a>{' '}
unless{'\n'}
you use a service account or other ways to authenticate (
unless you use a service account or other ways to authenticate (
<a href="https://stackoverflow.com/a/53307505/298182">more info</a>).
</p>
<CloudVersioning>
<a href="https://cloud.google.com/storage/docs/object-versioning">
Object versioning
</a>{' '}
enabled on the bucket.{'\n'}
enabled on the bucket.
</CloudVersioning>
<CustomAuth href="https://dvc.org/doc/user-guide/data-management/remote-storage/google-cloud-storage#custom-authentication" />
</div>
Expand Down
2 changes: 1 addition & 1 deletion webview/src/setup/components/remotes/styles.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
margin-top: 20px;

vscode-panels {
width: max-content;
width: 500px;
margin: 0 auto;
}
}
Expand Down

0 comments on commit 43b1697

Please sign in to comment.