Remove use of memo from table header and row

iterative · Aug 16, 2023 · 4bc7a44 · 4bc7a44
1 parent 7ea85d3
commit 4bc7a44
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/webview/src/experiments/components/table/body/Row.tsx b/webview/src/experiments/components/table/body/Row.tsx
@@ -1,5 +1,5 @@
 import cx from 'classnames'
-import React, { memo, useCallback, useMemo } from 'react'
+import React, { useCallback, useMemo } from 'react'
 import { useDispatch, useSelector } from 'react-redux'
 import { EXPERIMENT_WORKSPACE_ID } from 'dvc/src/cli/dvc/contract'
 import { StubCell, CellWrapper } from './Cell'
@@ -16,11 +16,9 @@ import {
   toggleRowSelected
 } from '../../../state/rowSelectionSlice'
 
-const Row: React.FC<RowProp & { className?: string; isExpanded: boolean }> = ({
-  row,
-  isExpanded,
-  className
-}): JSX.Element => {
+export const TableRow: React.FC<
+  RowProp & { className?: string; isExpanded: boolean }
+> = ({ row, isExpanded, className }): JSX.Element => {
   const changes = useSelector(
     (state: ExperimentsState) => state.tableData.changes
   )
@@ -119,5 +117,3 @@ const Row: React.FC<RowProp & { className?: string; isExpanded: boolean }> = ({
     </ContextMenu>
   )
 }
-
-export const TableRow = memo(Row)
diff --git a/webview/src/experiments/components/table/header/TableHead.tsx b/webview/src/experiments/components/table/header/TableHead.tsx
@@ -1,5 +1,5 @@
 import { Experiment } from 'dvc/src/experiments/webview/contract'
-import React, { DragEvent, useRef, useEffect, memo } from 'react'
+import React, { DragEvent, useRef, useEffect } from 'react'
 import { useSelector, useDispatch } from 'react-redux'
 import {
   Header,
@@ -28,7 +28,7 @@ interface TableHeadProps {
   setTableHeadHeight: (height: number) => void
 }
 
-const THead = ({
+export const TableHead = ({
   columnOrder,
   headerGroups,
   setColumnOrder,
@@ -135,5 +135,3 @@ const THead = ({
     </thead>
   )
 }
-
-export const TableHead = memo(THead)