Skip to content

Commit

Permalink
All plots sections visible (#2145)
Browse files Browse the repository at this point in the history
* Make all plot sections visible at all times

* Fix leaky tests and add empty state to the comparison table

* Pin storybook testing library

* Apply review comments

Co-authored-by: mattseddon <37993418+mattseddon@users.noreply.github.com>
  • Loading branch information
sroy3 and mattseddon authored Aug 5, 2022
1 parent a5b432e commit 5f98437
Show file tree
Hide file tree
Showing 10 changed files with 166 additions and 101 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ module.exports = {
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'no-undef': 'off',
'sonarjs/no-duplicate-string': 'off'
'sonarjs/no-duplicate-string': 'off',
'testing-library/no-render-in-setup': 'off'
}
},
{
Expand Down
3 changes: 1 addition & 2 deletions webview/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@
"vega-lite": "^5.2.0"
},
"devDependencies": {
"@storybook/testing-library": "^0.0.13",
"@storybook/testing-library": "0.0.13",
"@storybook/addon-essentials": "6.5.9",
"@storybook/addon-interactions": "6.5.9",
"@storybook/addons": "6.5.9",
"@storybook/builder-webpack5": "6.5.9",
"@storybook/manager-webpack5": "6.5.9",
"@storybook/preset-scss": "1.0.3",
"@storybook/react": "6.5.9",
"@storybook/testing-library": "0.0.13",
"@svgr/cli": "6.3.1",
"@testing-library/jest-dom": "5.16.4",
"@testing-library/react": "13.3.0",
Expand Down
Loading

0 comments on commit 5f98437

Please sign in to comment.