Skip to content

Commit

Permalink
improve names in base class
Browse files Browse the repository at this point in the history
  • Loading branch information
mattseddon committed Nov 4, 2021
1 parent 4509573 commit 89f750b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions extension/src/data/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export abstract class BaseData<
new EventEmitter<void>()
)

private readonly onDidChangeFiles: Event<void> =
private readonly onDidChangeCollectedFiles: Event<void> =
this.collectedFilesChanged.event

private watcher?: Disposable
Expand Down Expand Up @@ -76,7 +76,7 @@ export abstract class BaseData<
this.watcher = this.watchFiles()

this.dispose.track(
this.onDidChangeFiles(() => {
this.onDidChangeCollectedFiles(() => {
const watcher = this.watchFiles()
this.dispose.untrack(this.watcher)
this.watcher?.dispose()
Expand All @@ -99,12 +99,12 @@ export abstract class BaseData<

const files = this.collectFiles(data)

this.checkFilesUpdated(files)
this.compareFiles(files)

return this.notifyChanged(data)
}

private checkFilesUpdated(files: string[]) {
private compareFiles(files: string[]) {
if (sameContents(this.collectedFiles, files)) {
return
}
Expand Down

0 comments on commit 89f750b

Please sign in to comment.