Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
julieg18 committed Dec 22, 2023
1 parent de2d57d commit 9f5356a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import cx from 'classnames'
import { VSCodeProgressRing } from '@vscode/webview-ui-toolkit/react'
import styles from './styles.module.scss'

export const RevisionIcon: React.FC<{
export const LoadingIcon: React.FC<{
fetched: boolean
}> = ({ fetched }) => (
<div className={styles.iconPlaceholder}>
Expand Down
6 changes: 2 additions & 4 deletions webview/src/plots/components/ribbon/RibbonBlock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React from 'react'
import styles from './styles.module.scss'
import { RibbonBlockIcon } from './RibbonBlockIcon'
import { RibbonBlockTooltip } from './RibbonBlockTooltip'
import { RevisionIcon } from './RevisionIcon'
import { LoadingIcon } from './LoadingIcon'
import { Icon } from '../../../shared/components/Icon'
import Tooltip from '../../../shared/components/tooltip/Tooltip'
import { CopyButton } from '../../../shared/components/copyButton/CopyButton'
Expand Down Expand Up @@ -59,9 +59,7 @@ export const RibbonBlock: React.FC<RibbonBlockProps> = ({
</div>
)}
</div>
<div className={styles.iconPlaceholder}>
<RevisionIcon fetched={fetched} />
</div>
<LoadingIcon fetched={fetched} />
<Tooltip content="Clear" placement="bottom" delay={500}>
<button className={styles.clearButton} onClick={onClear}>
<Icon icon={Close} width={12} height={12} />
Expand Down
2 changes: 1 addition & 1 deletion webview/src/plots/components/ribbon/RibbonBlockIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const RibbonBlockIcon: React.FC<{
<Error
width={14}
height={14}
className={cx(styles.blockIcon, styles.error)}
className={cx(styles.blockIcon, styles.errorIndicator)}
aria-label="Error Icon"
/>
) : (
Expand Down

0 comments on commit 9f5356a

Please sign in to comment.