Add ability to sort by starred status (#2169)

iterative · Aug 10, 2022 · a4b4bbd · a4b4bbd
1 parent 49cf300
commit a4b4bbd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/extension/src/experiments/index.ts b/extension/src/experiments/index.ts
@@ -191,7 +191,9 @@ export class Experiments extends BaseRepository<TableData> {
 
   public async addSort() {
     const columns = this.columns.getTerminalNodes()
-    const sortToAdd = await pickSortToAdd(columns)
+    const columnLikes = addStarredToColumns(columns)
+
+    const sortToAdd = await pickSortToAdd(columnLikes)
     if (!sortToAdd) {
       return
     }

diff --git a/extension/src/experiments/model/sortBy/quickPick.ts b/extension/src/experiments/model/sortBy/quickPick.ts
@@ -3,10 +3,10 @@ import { definedAndNonEmpty } from '../../../util/array'
 import { quickPickManyValues, quickPickValue } from '../../../vscode/quickPick'
 import { Title } from '../../../vscode/title'
 import { Toast } from '../../../vscode/toast'
+import { ColumnLike } from '../../columns/like'
 import { pickFromColumnLikes } from '../../columns/quickPick'
-import { Column } from '../../webview/contract'
 
-export const pickSortToAdd = async (columns: Column[]) => {
+export const pickSortToAdd = async (columns: ColumnLike[] | undefined) => {
   const picked = await pickFromColumnLikes(columns, {
     title: Title.SELECT_PARAM_OR_METRIC_SORT
   })