Remove max version of CLI (3.0 release)

iterative · Jun 6, 2023 · ba483ae · ba483ae
1 parent dd7eac8
commit ba483ae
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 29 deletions.
diff --git a/extension/src/cli/dvc/contract.ts b/extension/src/cli/dvc/contract.ts
@@ -2,7 +2,6 @@ import { Plot } from '../../plots/webview/contract'
 
 export const MIN_CLI_VERSION = '2.58.1'
 export const LATEST_TESTED_CLI_VERSION = '2.58.2'
-export const MAX_CLI_VERSION = '3'
 
 type ErrorContents = { type: string; msg: string }
 

diff --git a/extension/src/cli/dvc/version.ts b/extension/src/cli/dvc/version.ts
@@ -1,8 +1,4 @@
-import {
-  LATEST_TESTED_CLI_VERSION,
-  MAX_CLI_VERSION,
-  MIN_CLI_VERSION
-} from './contract'
+import { LATEST_TESTED_CLI_VERSION, MIN_CLI_VERSION } from './contract'
 
 export enum CliCompatible {
   NO_CANNOT_VERIFY = 'no-cannot-verify',
@@ -38,13 +34,12 @@ const checkCLIVersion = (currentSemVer: {
     patch: minPatch
   } = extractSemver(MIN_CLI_VERSION) as ParsedSemver
 
-  const isAheadMaxVersion = currentMajor >= Number(MAX_CLI_VERSION)
   const isBehindMinVersion =
     currentMajor < minMajor ||
     currentMinor < minMinor ||
     (currentMinor === minMinor && currentPatch < Number(minPatch))
 
-  if (isAheadMaxVersion || isBehindMinVersion) {
+  if (isBehindMinVersion) {
     return CliCompatible.NO_INCOMPATIBLE
   }
 

diff --git a/extension/src/setup/runner.test.ts b/extension/src/setup/runner.test.ts
@@ -514,27 +514,6 @@ describe('run', () => {
     expect(mockedInitialize).not.toHaveBeenCalled()
   })
 
-  it('should send a specific message to the user if the located CLI is a major version ahead', async () => {
-    const MajorAhead = MIN_CLI_VERSION.split('.')
-      .map(num => Number(num) + 100)
-      .join('.')
-    mockedGetFirstWorkspaceFolder.mockReturnValueOnce(mockedCwd)
-    mockedShouldWarnUserIfCLIUnavailable.mockReturnValueOnce(true)
-    mockedIsPythonExtensionUsed.mockResolvedValueOnce(true)
-    mockedGetCliVersion.mockResolvedValueOnce(MajorAhead)
-
-    await run(setup)
-    await flushPromises()
-    expect(mockedWarnWithOptions).toHaveBeenCalledTimes(1)
-    expect(mockedWarnWithOptions).toHaveBeenCalledWith(
-      'The extension cannot initialize because the DVC CLI version is incompatible.',
-      'Setup'
-    )
-    expect(mockedGetCliVersion).toHaveBeenCalledTimes(1)
-    expect(mockedResetMembers).toHaveBeenCalledTimes(1)
-    expect(mockedInitialize).not.toHaveBeenCalled()
-  })
-
   it('should send a specific message to the user if the Python extension is being used, the CLI is not available in the virtual environment and no cli is found globally', async () => {
     mockedGetFirstWorkspaceFolder.mockReturnValueOnce(mockedCwd)
     mockedHasRoots.mockReturnValueOnce(true)