Remove + button in custom plots section

iterative · Sep 20, 2023 · ec3c5ed · ec3c5ed
1 parent 6233c89
commit ec3c5ed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 31 deletions.
diff --git a/webview/src/plots/components/App.test.tsx b/webview/src/plots/components/App.test.tsx
@@ -766,25 +766,6 @@ describe('App', () => {
     })
   })
 
-  it('should hide the custom plots add button if there are no more plots to create', () => {
-    renderAppWithOptionalData({
-      comparison: comparisonTableFixture,
-      custom: customPlotsFixture
-    })
-
-    const customSection = screen.getAllByTestId('section-container')[2]
-
-    expect(within(customSection).getByLabelText('Add Plot')).toBeInTheDocument()
-
-    sendSetDataMessage({
-      custom: { ...customPlotsFixture, enablePlotCreation: false }
-    })
-
-    expect(
-      within(customSection).queryByLabelText('Add Plot')
-    ).not.toBeInTheDocument()
-  })
-
   it('should display a slider to pick the number of items per row if there are items and the action is available', () => {
     const store = renderAppWithOptionalData({
       custom: customPlotsFixture

diff --git a/webview/src/plots/components/customPlots/CustomPlotsWrapper.tsx b/webview/src/plots/components/customPlots/CustomPlotsWrapper.tsx
@@ -5,17 +5,11 @@ import { CustomPlots } from './CustomPlots'
 import { changeSize } from './customPlotsSlice'
 import { PlotsContainer } from '../PlotsContainer'
 import { PlotsState } from '../../store'
-import { addCustomPlot, removeCustomPlots } from '../../util/messages'
+import { removeCustomPlots } from '../../util/messages'
 
 export const CustomPlotsWrapper: React.FC = () => {
-  const {
-    plotsIds,
-    nbItemsPerRow,
-    isCollapsed,
-    height,
-    enablePlotCreation,
-    hasAddedPlots
-  } = useSelector((state: PlotsState) => state.custom)
+  const { plotsIds, nbItemsPerRow, isCollapsed, height, hasAddedPlots } =
+    useSelector((state: PlotsState) => state.custom)
   const [selectedPlots, setSelectedPlots] = useState<string[]>([])
   useEffect(() => {
     setSelectedPlots(plotsIds)
@@ -29,9 +23,6 @@ export const CustomPlotsWrapper: React.FC = () => {
       sectionKey={PlotsSection.CUSTOM_PLOTS}
       nbItemsPerRowOrWidth={nbItemsPerRow}
       sectionCollapsed={isCollapsed}
-      addPlotsButton={
-        enablePlotCreation ? { onClick: addCustomPlot } : undefined
-      }
       removePlotsButton={
         hasAddedPlots ? { onClick: removeCustomPlots } : undefined
       }