return string version of the array to the experiments table to match CLI

iterative · Jun 2, 2022 · f7249d7 · f7249d7
1 parent 12d7d52
commit f7249d7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/webview/src/experiments/util/buildDynamicColumns.test.ts b/webview/src/experiments/util/buildDynamicColumns.test.ts
@@ -54,6 +54,22 @@ describe('buildDynamicColumns', () => {
       },
       {
         columns: [
+          {
+            columns: [
+              {
+                id: joinColumnPath(
+                  ColumnType.PARAMS,
+                  'params.yaml',
+                  'code_names'
+                )
+              }
+            ],
+            id: joinColumnPath(
+              ColumnType.PARAMS,
+              'params.yaml',
+              'code_names_previous_placeholder'
+            )
+          },
           {
             columns: [
               {

diff --git a/webview/src/experiments/util/buildDynamicColumns.tsx b/webview/src/experiments/util/buildDynamicColumns.tsx
@@ -83,8 +83,13 @@ const Header: React.FC<{ column: TableColumn<Experiment> }> = ({
 }
 
 const buildAccessor: (valuePath: string[]) => Accessor<Experiment> =
-  pathArray => originalRow =>
-    get(originalRow, pathArray)
+  pathArray => originalRow => {
+    const value = get(originalRow, pathArray)
+    if (!Array.isArray(value)) {
+      return value
+    }
+    return JSON.stringify(value)
+  }
 
 const buildDynamicColumns = (
   properties: Column[],