Move telemetry event

iterative · Jun 30, 2023 · f7974bb · f7974bb
1 parent 9daac17
commit f7974bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/extension/src/plots/webview/messages.ts b/extension/src/plots/webview/messages.ts
@@ -345,12 +345,6 @@ export class WebviewMessages {
  }
 
  private async exportPlotAsRawData(plotId: string, data?: PlainObject) {
- sendTelemetryEvent(
- EventName.VIEWS_PLOTS_EXPORT_PLOT_AS_RAW_DATA,
- undefined,
- undefined
- )
-
  const file = await window.showSaveDialog({
  defaultUri: Uri.file('data.json'),
  filters: { JSON: ['json'] }
@@ -360,6 +354,12 @@ export class WebviewMessages {
  return
  }
 
+ sendTelemetryEvent(
+ EventName.VIEWS_PLOTS_EXPORT_PLOT_AS_RAW_DATA,
+ undefined,
+ undefined
+ )
+
  const selectedRevisions = this.plots.getSelectedRevisionDetails()
 
  this.plots.saveAsPlotRawData(selectedRevisions, plotId, file.path, data)

diff --git a/extension/src/test/suite/plots/index.test.ts b/extension/src/test/suite/plots/index.test.ts
@@ -507,12 +507,7 @@ suite('Plots Test Suite', () => {
 
  expect(mockWriteJson).not.to.be.calledOnce
  expect(mockOpenFile).not.to.be.calledOnce
- expect(mockSendTelemetryEvent).to.be.called
- expect(mockSendTelemetryEvent).to.be.calledWithExactly(
- EventName.VIEWS_PLOTS_EXPORT_PLOT_AS_RAW_DATA,
- undefined,
- undefined
- )
+ expect(mockSendTelemetryEvent).not.to.be.called
 
  const exportFileEvent = new Promise(resolve =>
  mockShowSaveDialog.onSecondCall().callsFake(() => {