Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how timestamp column formats times #1444

Closed
2 tasks
rogermparent opened this issue Mar 14, 2022 · 2 comments
Closed
2 tasks

Improve how timestamp column formats times #1444

rogermparent opened this issue Mar 14, 2022 · 2 comments
Labels
A: experiments Area: experiments table webview and everything related priority-p2 Future feature, less priority for now 📦 product Needs product input or is being actively worked on

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Mar 14, 2022

From a discussion with the Studio and DVC teams on Slack, we've come to the following changes beyond #1333

  • Use a format derived from ISO 8601 (YYYY-MM-DD+24h) by default
  • Allow for the user to configure timestamp formatting

For reference, here's a recording of the current timestamps:

new-timestamp-demo.mp4

Since Javascript's built-in time formatting doesn't include a configurable formatting (at least in the usual Y/M/D template sense most people are familiar with), we'll want to introduce a library to handle this- likely date-fns, as it's a popular minimal library for date formatting that is also what Studio uses for its date formatting.


Related to #2031

@rogermparent rogermparent added the product PR that affects product label Mar 14, 2022
@mattseddon mattseddon added the A: experiments Area: experiments table webview and everything related label Mar 15, 2022
@rogermparent rogermparent added the priority-p2 Future feature, less priority for now label Mar 31, 2022
@rogermparent rogermparent changed the title Update Timestamps Improve how timestamp column formats times Jul 21, 2022
@maxagin
Copy link
Contributor

maxagin commented Jul 25, 2022

Timestamp column improvements #2031

@mattseddon mattseddon added 📦 product Needs product input or is being actively worked on and removed status: 🥁 ready-for-development product PR that affects product labels Aug 5, 2022
@shcheklein
Copy link
Member

Closing this for, since it's not critical and we've done an iteration recently. Next step should be to add time it took for an experiment to run, not improving this format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related priority-p2 Future feature, less priority for now 📦 product Needs product input or is being actively worked on
Projects
None yet
Development

No branches or pull requests

4 participants