Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date for branch, time for exp rows #2050

Closed
maxagin opened this issue Jul 16, 2022 · 12 comments
Closed

Date for branch, time for exp rows #2050

maxagin opened this issue Jul 16, 2022 · 12 comments
Assignees
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p2 Future feature, less priority for now

Comments

@maxagin
Copy link
Contributor

maxagin commented Jul 16, 2022

DVC has date only for the branch, the expS have the time. Why can not we do the same?

Screen Shot 2022-07-15 at 11 26 29 PM

@maxagin maxagin added discussion A: experiments Area: experiments table webview and everything related labels Jul 16, 2022
@shcheklein
Copy link
Member

Max, sorry, closing this since it's not actionable . What do those dates mean? What do we actually want from those dates (what problem do they solve?), etc - the ticket ideally should be described like that. Please feel free to reopen if you are able to provide more context / information to this.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 18, 2022

@shcheklein , the screenshot in the description is from DVC (or I am wrong?).
My question is why does DVC have it one way and VSCode, another way? That is it. Thanks

@shcheklein
Copy link
Member

@maxagin yep, my point I guess is for this ticket to be more or less actionable - let's ask the DVC, put together some description, some logic behind it, etc. I would make it easier to say if it makes sense or not.

@mattseddon
Copy link
Member

Should be combined with #1444

@mattseddon
Copy link
Member

and #2031

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

@maxagin yep, my point I guess is for this ticket to be more or less actionable - let's ask the DVC, put together some description, some logic behind it, etc. I would make it easier to say if it makes sense or not.

Hello @dberenbaum , would you be so kind to clarify for us the logic behind the information on the screenshot in the description of this ticket? Thank you Dave!

@dberenbaum
Copy link
Contributor

While I don't remember conversations about the format, I believe the rationale was to show times for today's experiments since they are the most recent and important to compare at a granular level, while the exact time of each experiment is not as important for older experiments.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

Thank you Dave for the clarification!

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

Show times for today's experiments since they are the most recent and important to compare at a granular level

@dberenbaum how does actually the time will help to compare EXPs (or checkpoints)?
Maybe users will more likely be interested to know the range of time one run took?

Q: Do the checkpoints of one EXP, can have different dates?

@dberenbaum
Copy link
Contributor

@dberenbaum how does actually the time will help to compare EXPs (or checkpoints)?

It doesn't help compare them, but it sometimes helps organize them. Seeing that this experiment was run a week ago might help me remember something about it or see quickly that it's not part of my current set of experiments. It's less important for different times on the same day, but it still helps me see the order in which I ran the experiments, which can help organize them in my mind at least.

Maybe users will more likely be interested to know the range of time one run took?

Yes, the time it took to run an experiment could be helpful. We have discussed adding that to DVC (iterative/dvc#7160) but right now there's no functionality to provide that info.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 20, 2022

Sounds good @dberenbaum ! Thank you.

@maxagin maxagin added enhancement New feature or request priority-p2 Future feature, less priority for now status: 🎨 design-in-progress and removed research labels Jul 20, 2022
@mattseddon mattseddon added 🎨 design Needs design input or is being actively worked on and removed status: 🎨 design-in-progress labels Aug 5, 2022
@shcheklein
Copy link
Member

Closing this since it's not important at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p2 Future feature, less priority for now
Projects
None yet
Development

No branches or pull requests

4 participants