Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment colors hard to see (default themes) #1597

Closed
2 tasks done
mattseddon opened this issue Apr 21, 2022 · 1 comment
Closed
2 tasks done

Experiment colors hard to see (default themes) #1597

mattseddon opened this issue Apr 21, 2022 · 1 comment
Assignees
@wolmir @mattseddon
Labels
A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related product PR that affects product

Comments

@mattseddon
Copy link
Member

mattseddon commented Apr 21, 2022 •
edited
Loading

From testing iterative/dvc#7574:

We have some experiment colors that really clash with the default themes.

Screen Shot 2022-04-21 at 1 41 42 pm

image

image

I think we should prioritise fixing up the ones that are almost invisible with respect to the dark theme.
We also need to fix the fact that sort indicators are hidden on light themes. We should be able to change the highlight to a built-in color.

  • Change the way that we display selected experiments - uncolored empty circle for unselected, colored filled circle for selected (limit colors to iterative color palette)
  • Fix sort indicator by using a builtin color
@mattseddon mattseddon added A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related product PR that affects product labels Apr 21, 2022
@mattseddon
Copy link
Member Author

We can only select 7 revisions now. Maybe we should set unselected revisions back to the default color and only use the same colors that Studio does?!?!?!

@sroy3 sroy3 mentioned this issue Apr 21, 2022
Closed
3 tasks
@wolmir wolmir self-assigned this Apr 21, 2022
@mattseddon mattseddon assigned mattseddon and wolmir and unassigned wolmir Apr 21, 2022
wolmir added a commit that referenced this issue Apr 26, 2022
@wolmir
Fix sorting indicator color (#1597)
d4815fc
@wolmir wolmir mentioned this issue Apr 26, 2022
Merged
wolmir added a commit that referenced this issue Apr 27, 2022
@wolmir
Fix sorting indicator color (#1597)
16102e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolmir wolmir

@mattseddon mattseddon

Labels
A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related product PR that affects product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolmir @mattseddon