Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu, tooltips, hints. Curved line & first color in plots / VS Code DVC #1608

Closed
maxagin opened this issue Apr 22, 2022 · 2 comments
Closed
Assignees
Labels
🎨 design Needs design input or is being actively worked on

Comments

@maxagin
Copy link
Contributor

maxagin commented Apr 22, 2022

Sharing some examples based on my and @mattseddon discussion + some other general improvements. If needed let's jump on call to discuss this changes.
Figma file

@maxagin maxagin added the 🎨 design Needs design input or is being actively worked on label Apr 22, 2022
@maxagin
Copy link
Contributor Author

maxagin commented Apr 22, 2022

@shcheklein please let me know if this is right way to create a task on GitHub. Thanks !

@maxagin maxagin changed the title Context menu, tooltips, hints. Curved line & first color in plots Context menu, tooltips, hints. Curved line & first color in plots / VS Code DVC Apr 23, 2022
@mattseddon
Copy link
Member

@maxagin

I rolled the context menus feedback in with #1603.

Rounded plots lines -> We cannot easily update plots to have rounded lines. IMO it would be better to leave the template as is. If we update the behaviour for Vega we would have to do the same thing for all of the upcoming plots providers as DVC starts to accommodate them as well. Having rounded lines for plots also runs against all of the straight edges shown in the rest of VS Code.

Using grey color as the default for plotting -> We are currently debating the behaviour of selecting revisions from the experiments table. The behaviour will be updated in #1607 but may change again based on the decisions in #1565 (see Toggling plots visibility concept). One thing to note is that currently whatever color we use for the dark theme will be reflected in the light theme. This is due to some limitations with the way that VS Code works.

Will close this one for now. LMK if I have missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on
Projects
None yet
Development

No branches or pull requests

2 participants