Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle revisions from webview #1607

Merged
merged 13 commits into from
Apr 28, 2022
Merged

Toggle revisions from webview #1607

merged 13 commits into from
Apr 28, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Apr 22, 2022

Screen.Recording.2022-04-22.at.10.45.39.AM.mov

Will still need to persist the state

@sroy3 sroy3 added the product PR that affects product label Apr 22, 2022
@sroy3 sroy3 self-assigned this Apr 22, 2022
@sroy3 sroy3 changed the base branch from main to separate-plots-file April 22, 2022 14:24
@sroy3 sroy3 marked this pull request as ready for review April 22, 2022 15:37
@rogermparent
Copy link
Contributor

I'm getting some cut off text on the menu

image

Base automatically changed from separate-plots-file to main April 25, 2022 12:33
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My cut-off issue is fixed!
image

Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in our catch up this morning. Happy to merge as is but this raises a lot of product questions.

@sroy3 sroy3 enabled auto-merge (squash) April 28, 2022 16:04
@codeclimate
Copy link

codeclimate bot commented Apr 28, 2022

Code Climate has analyzed commit deb47c1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 96.7% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 0c06a40 into main Apr 28, 2022
@sroy3 sroy3 deleted the comparison-revision-toggle branch April 28, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants