-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plots: How to display images and plots per step #1640
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Started working on the UX of the our "image per step" comparison plots! Here's what we've got so far (all in Storybook for now since backend implementation isn't done yet): I based the slider off of our Mostly Working Demo: Screen.Recording.2023-07-20.at.12.02.49.PM.movWhat do we think? cc @shcheklein |
Would be great to sync the step slider across all images, but otherwise LGTM! |
I thinks it's a perfect start @julieg18 ! |
Depends on iterative/dvclive#425
In the current demo setup, we override the saved image and plot at the end of each step.
Unless using checkpoints, this makes it impossible to visualize images and plots logged at previous steps. And even using checkpoints the current UI doesn't easily allow to check the image and plot from previous steps (requires
Apply to workspace
and refreshing the view)In order to enable visualizing images from previous steps with or without checkpoints, in dvclive we implemented the(not true anymore, need to reconsider this, edited by @shcheklein)log_image
function in a way that images are saved under astep
subfolder (https://dvc.org/doc/dvclive/api-reference/live/log_image#step-updates).However, using
log_image
in the VSCode UI produces a noisy output, as eachstep
image is displayed in an individual row:I believe that allowing to display "per-step" images and plots is a relevant scenario for VSCode.
In tensorboard, logging an image each step gets rendered using a slider:
Related iterative/dvc-render#6
The text was updated successfully, but these errors were encountered: