Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: How to display images and plots per step #1640

Closed
daavoo opened this issue May 2, 2022 · 18 comments · Fixed by #4319
Closed

plots: How to display images and plots per step #1640

daavoo opened this issue May 2, 2022 · 18 comments · Fixed by #4319
Assignees
Labels
A: plots Area: plots webview, side panel and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p1 Regular product backlog 📦 product Needs product input or is being actively worked on triage

Comments

@daavoo
Copy link
Contributor

daavoo commented May 2, 2022

Depends on iterative/dvclive#425

In the current demo setup, we override the saved image and plot at the end of each step.

Unless using checkpoints, this makes it impossible to visualize images and plots logged at previous steps. And even using checkpoints the current UI doesn't easily allow to check the image and plot from previous steps (requires Apply to workspace and refreshing the view)

In order to enable visualizing images from previous steps with or without checkpoints, in dvclive we implemented the log_image function in a way that images are saved under a step subfolder (https://dvc.org/doc/dvclive/api-reference/live/log_image#step-updates). (not true anymore, need to reconsider this, edited by @shcheklein)

However, using log_image in the VSCode UI produces a noisy output, as each step image is displayed in an individual row:

Captura de Pantalla 2022-05-02 a las 17 49 21

I believe that allowing to display "per-step" images and plots is a relevant scenario for VSCode.


In tensorboard, logging an image each step gets rendered using a slider:

confusion matrix
predictions


Related iterative/dvc-render#6

@daavoo daavoo added the A: plots Area: plots webview, side panel and everything related label May 2, 2022
@daavoo daavoo changed the title plots: How to display images per step plots: How to display images/plots per step May 2, 2022
@daavoo daavoo changed the title plots: How to display images/plots per step plots: How to display images and plots per step May 2, 2022
@daavoo daavoo added the 🎨 design Needs design input or is being actively worked on label May 2, 2022
@mattseddon

This comment was marked as outdated.

@maxagin maxagin added the enhancement New feature or request label Jun 22, 2022
@maxagin

This comment was marked as outdated.

@shcheklein

This comment was marked as outdated.

@shcheklein

This comment was marked as outdated.

@daavoo

This comment was marked as outdated.

@shcheklein

This comment was marked as outdated.

@dberenbaum

This comment was marked as outdated.

@daavoo

This comment was marked as outdated.

@dberenbaum

This comment was marked as outdated.

@shcheklein

This comment was marked as outdated.

@daavoo

This comment was marked as outdated.

@shcheklein

This comment was marked as outdated.

@dberenbaum

This comment was marked as outdated.

@shcheklein shcheklein added the 📦 product Needs product input or is being actively worked on label Jan 13, 2023
@shcheklein

This comment was marked as outdated.

@dberenbaum

This comment was marked as outdated.

@julieg18 julieg18 self-assigned this Jul 18, 2023
@shcheklein shcheklein added the priority-p1 Regular product backlog label Jul 18, 2023
@shcheklein shcheklein removed their assignment Jul 18, 2023
@julieg18
Copy link
Contributor

Started working on the UX of the our "image per step" comparison plots! Here's what we've got so far (all in Storybook for now since backend implementation isn't done yet):

image

I based the slider off of our .vega-actions design that we use for vega smooth plots but we can style it any way we want since this isn't a vega plot.

Mostly Working Demo:

Screen.Recording.2023-07-20.at.12.02.49.PM.mov

What do we think? cc @shcheklein

@dberenbaum
Copy link
Contributor

Would be great to sync the step slider across all images, but otherwise LGTM!

@shcheklein
Copy link
Member

What do we think? cc @shcheklein

I thinks it's a perfect start @julieg18 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Area: plots webview, side panel and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p1 Regular product backlog 📦 product Needs product input or is being actively worked on triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants