Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots per step #4452

Closed
daavoo opened this issue Aug 8, 2023 · 9 comments
Closed

Plots per step #4452

daavoo opened this issue Aug 8, 2023 · 9 comments
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request

Comments

@daavoo
Copy link
Contributor

daavoo commented Aug 8, 2023

Loving the Images per step slider!

I think it would be awesome if we could extend the logic for non-linear Plots (i.e. confusion matrix).

Like:

import random

from dvclive import Live

with Live(report=None, save_dvc_exp=True) as live:
    y_true = [0, 0, 1, 1]
    for i in range(10):
        y_pred = [int(random.random() > 0.5) for _ in range(4)]
        live.log_sklearn_plot(
            "confusion_matrix", y_true, y_pred, 
            name=f"confusion_matrix/{i}.json")
        live.next_step()
@daavoo daavoo added enhancement New feature or request A: plots Area: plots webview, side panel and everything related labels Aug 8, 2023
@mattseddon mattseddon added priority-p1 Regular product backlog research labels Aug 8, 2023
@dberenbaum
Copy link
Contributor

@daavoo Do you have any use cases where a confusion matrix is saved per step? Not to push back (the idea sounds good), just curious how important you see it since I see it's marked p1.

@daavoo
Copy link
Contributor Author

daavoo commented Aug 10, 2023

@daavoo Do you have any use cases where a confusion matrix is saved per step? Not to push back (the idea sounds good), just curious how important you see it since I see it's marked p1.

Out of my context if it is p1 . I consider it an useful thing / as relevant as the image support (one of the GIFs I put in #1640 is a confusion matrix), but it is not a deal breaker

@dberenbaum
Copy link
Contributor

If that's the behavior you want, maybe it's better to save the confusion matrix as an image?

@dberenbaum
Copy link
Contributor

I would say let's discuss before doing research in vega since we don't want to keep investing in vega.

@daavoo
Copy link
Contributor Author

daavoo commented Aug 10, 2023

If that's the behavior you want, maybe it's better to save the confusion matrix as an image?
I would say let's discuss before doing research in vega since we don't want to keep investing in vega.

Yes, makes sense, sorry for the lack of clarity I was answering about the usefulness of the confusion matrix per steps.

@dberenbaum
Copy link
Contributor

Yup, agree with everything you wrote, and sorry if I'm being a downer. I just want to clarify before anyone spends too much time here on the wrong idea.

@julieg18
Copy link
Contributor

It was made p1 for now in planning meeting. I'm starting out with researching how easy it is to implement.

@julieg18
Copy link
Contributor

Did some research, it should be doable but implementing in the frontend will be a a bit more difficult since template plots have a lot more complexity happening than our image plots. As discussed in planning, going to deprioritize this for the time being.

@julieg18 julieg18 removed priority-p1 Regular product backlog research labels Aug 15, 2023
@julieg18 julieg18 removed their assignment Aug 15, 2023
@shcheklein
Copy link
Member

I guess let's get to plotly first, then we can come back to things like this folks.

@shcheklein shcheklein closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants