Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-select context menu to experiments webview #1663

Closed
mattseddon opened this issue May 6, 2022 · 7 comments
Closed

Add multi-select context menu to experiments webview #1663

mattseddon opened this issue May 6, 2022 · 7 comments
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request

Comments

@mattseddon
Copy link
Member

Now that we have a context menu available in the experiments webview we need to extend it to handle actions on multiple selected rows:

image

More details and flows in the Figma spec and probably in #1562.

The only action that I can think of that is applicable to a list of selected experiments is "remove" but I could be wrong.

@wolmir
Copy link
Contributor

wolmir commented Jun 14, 2022

@maxagin @shcheklein @mattseddon The context menu is disabled when any experiment is running.
Should the row selection be disabled as well?

@mattseddon
Copy link
Member Author

Yes, the same conditions should apply.

@wolmir
Copy link
Contributor

wolmir commented Jun 14, 2022

@maxagin

Screen.Recording.2022-06-14.at.16.29.56.mov

@maxagin
Copy link
Contributor

maxagin commented Jun 14, 2022

Great work @wolmir ! Tiny comment: When you add the select style you may consider not using the border (top/bottom) at all, as they are moving the other rows :) - unwanted movement.

@maxagin
Copy link
Contributor

maxagin commented Jun 14, 2022

I think that if the exp is running I still want to be able to remove it, but just to remove it. WDYT?

@mattseddon
Copy link
Member Author

Discussed on the weekly planning call:

  1. Logic in the table should replicate logic shown in the tree (see collectDeletable).
  2. Can stop a running experiment which is equivalent to deleting it.

@mattseddon
Copy link
Member Author

We have a multi-select context menu now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants