-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-select context menu to experiments webview #1663
Comments
@maxagin @shcheklein @mattseddon The context menu is disabled when any experiment is running. |
Yes, the same conditions should apply. |
Screen.Recording.2022-06-14.at.16.29.56.mov |
Great work @wolmir ! Tiny comment: When you add the select style you may consider not using the border (top/bottom) at all, as they are moving the other rows :) - unwanted movement. |
I think that if the exp is running I still want to be able to remove it, but just to remove it. WDYT? |
Discussed on the weekly planning call:
|
We have a multi-select context menu now. |
Now that we have a context menu available in the experiments webview we need to extend it to handle actions on multiple selected rows:
More details and flows in the Figma spec and probably in #1562.
The only action that I can think of that is applicable to a list of selected experiments is "remove" but I could be wrong.
The text was updated successfully, but these errors were encountered: