-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for launching per-row actions from the table webview #1267
Comments
I have had the request to toggle experiments on/off from the table today. I would expect this would be done via left-click on or around the dot shown at the start of the experiment row. This will interfere with the current behaviour of collapsing the row but should be achievable. I am going to pair with @sroy3 on the problem later in the week. LMK if you see any issue with this. Thanks, |
I'm starting on this, and likely looking at the "right click for context menu" route since it doesn't step on our current left-click toggle behavior. |
Do we expect that we'll have any context menu actions in the future that operate on individual cells as well as rows? I just had the thought and made #1517 in anticipation (though it seems like a good change on its own) but I can't gleam any from the OP, so I'll be working under the assumption that it'll be rows only for now. |
Inline edit of params is one example |
True, but I was thinking specifically of cells that aren't in the workspace. Maybe a "copy value to workspace", similar to apply but for a single param? |
Yeah, that would be low priority |
This is the last open item from #239 |
Add context menu payload with item details from webview Add non-wired context menu Revert broken label Add rough functional wiring Refactor context menu Create context menu component Open context menu on row Use original implementation of the context-menu Create MessagesMenu component Update context-menu story Use messages-menu in the table rows Process experiment row ctx-menu messages Remove context-menu webview message Refactor Row.tsx Refactor Experiments constructor Remove commented line Add tests for apply to workspace and create branch Fis option labels Add test for Modify params and queue option Add test for Experiment Removed message Prevent default menu from showing up when we close ours Make runCommand private in extension Experiments repository Stub internalCommand instance method instead of the prototype Refactor mock input box utility Disable row context-menu if the experiment is running Hide context menu on click Disable the 'Apply to workspace' and 'Create branch' options when row is workspace or already a branch Extract row context-menu into a separate component Do not use the constructor shortcut in order to keep consistency Refactor option label and contextMenuOptions function Refactor Experiments repository constructor Refactor Experiments modifyExperimentParamsAndQueue Remove unused interface Disable context-menu if an y experiment is running
Add context menu payload with item details from webview Add non-wired context menu Revert broken label Add rough functional wiring Refactor context menu Create context menu component Open context menu on row Use original implementation of the context-menu Create MessagesMenu component Update context-menu story Use messages-menu in the table rows Process experiment row ctx-menu messages Remove context-menu webview message Refactor Row.tsx Refactor Experiments constructor Remove commented line Add tests for apply to workspace and create branch Fis option labels Add test for Modify params and queue option Add test for Experiment Removed message Prevent default menu from showing up when we close ours Make runCommand private in extension Experiments repository Stub internalCommand instance method instead of the prototype Refactor mock input box utility Disable row context-menu if the experiment is running Hide context menu on click Disable the 'Apply to workspace' and 'Create branch' options when row is workspace or already a branch Extract row context-menu into a separate component Do not use the constructor shortcut in order to keep consistency Refactor option label and contextMenuOptions function Refactor Experiments repository constructor Refactor Experiments modifyExperimentParamsAndQueue Remove unused interface Disable context-menu if an y experiment is running Report the command id when throwng a not found error Undo workspace refactor
Add context menu payload with item details from webview Add non-wired context menu Revert broken label Add rough functional wiring Refactor context menu Create context menu component Open context menu on row Use original implementation of the context-menu Create MessagesMenu component Update context-menu story Use messages-menu in the table rows Process experiment row ctx-menu messages Remove context-menu webview message Refactor Row.tsx Refactor Experiments constructor Remove commented line Add tests for apply to workspace and create branch Fis option labels Add test for Modify params and queue option Add test for Experiment Removed message Prevent default menu from showing up when we close ours Make runCommand private in extension Experiments repository Stub internalCommand instance method instead of the prototype Refactor mock input box utility Disable row context-menu if the experiment is running Hide context menu on click Disable the 'Apply to workspace' and 'Create branch' options when row is workspace or already a branch Extract row context-menu into a separate component Do not use the constructor shortcut in order to keep consistency Refactor option label and contextMenuOptions function Refactor Experiments repository constructor Refactor Experiments modifyExperimentParamsAndQueue Remove unused interface Disable context-menu if an y experiment is running Report the command id when throwng a not found error Undo workspace refactor Refactor contextMenuOptions function in Row.tsx
Add context menu payload with item details from webview Add non-wired context menu Revert broken label Add rough functional wiring Refactor context menu Create context menu component Open context menu on row Use original implementation of the context-menu Create MessagesMenu component Update context-menu story Use messages-menu in the table rows Process experiment row ctx-menu messages Remove context-menu webview message Refactor Row.tsx Refactor Experiments constructor Remove commented line Add tests for apply to workspace and create branch Fis option labels Add test for Modify params and queue option Add test for Experiment Removed message Prevent default menu from showing up when we close ours Make runCommand private in extension Experiments repository Stub internalCommand instance method instead of the prototype Refactor mock input box utility Disable row context-menu if the experiment is running Hide context menu on click Disable the 'Apply to workspace' and 'Create branch' options when row is workspace or already a branch Extract row context-menu into a separate component Do not use the constructor shortcut in order to keep consistency Refactor option label and contextMenuOptions function Refactor Experiments repository constructor Refactor Experiments modifyExperimentParamsAndQueue Remove unused interface Disable context-menu if an y experiment is running Report the command id when throwng a not found error Undo workspace refactor Refactor contextMenuOptions function in Row.tsx
Lifted multi-select into #1663 |
This issue tracks the ability to run commands on individual experiments from the experiments table webview.
We currently have a few commands that do this:
But they currently run on vscode-native quickpicks that display a list of experiments. These commands will have to be modified so that they can be called from the webview with a pre-filled experiment.
We currently have a design proposal for this using a context menu, though it's not set in stone:
Single row actions preview:
Multiple rows actions preview:
More details and flows in the Figma spec.
This Issue is a slight superset of #1135, but they're close enough that we can merge that one into this issue:
#1135: Action per item to run experiments
Originated at #1120 (comment)
Single new experiment
We should be able to run experiments based on any of the experiments in the table or workspace.
Batch
Concerns:
I think it makes sense for advanced scenarios and especially when experiments are expensive to run (deep learning), in case of "classical" DS random forest, xgboost it's easier to run a small grid batch .
I would add some basic way to specify a list of values at least and/or simple start-step-end UI.
The text was updated successfully, but these errors were encountered: