Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: Experiments workflow #239

Closed
12 tasks done
shcheklein opened this issue Apr 5, 2021 · 6 comments
Closed
12 tasks done

Story: Experiments workflow #239

shcheklein opened this issue Apr 5, 2021 · 6 comments
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on priority-p1 Regular product backlog story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc

Comments

@shcheklein
Copy link
Member

shcheklein commented Apr 5, 2021

Motivation

Ability to run/stop/resume/queue experiments as reflected by the dvc exp is considered one of the key features we'd like to release as part of the initial version. Motivation behind the corresponding DVC functionality can be found in docs or briefly in this blog.

To play with the experiments online: https://katacoda.com/dvc/courses/get-started/experiments

Tickets

New tickets and scope might come as we have some initial design input from @yalozhkin .

Details

As we discussed we start the following scope:

  • Run an experiment in the workspace - this is default and it is done to some extent. But might require changes from the design perspective.

  • Queue experiments run --queue and run them all --run-all

  • an action to stop and experiment(s) by sending a SIGTERM

  • Reset to run from "scratch": run --reset

  • Apply (get) the experiment - apply

  • Branch (get as a branch) the experiment - branch

  • Remove an experiment(s) - remove

Only after that when we have more clarity, probably after the initial release we can do "remote" commands

  • push, pull, list

Design

The running experiments workflow includes:

  • The Runs panel with toolbar
  • The Experiments table with toolbar

A running experiment preview:
image

More details and states in the Figma spec.

cc @yalozhkin

@shcheklein shcheklein added story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc 🎨 design Needs design input or is being actively worked on labels Apr 5, 2021
@shcheklein shcheklein changed the title Story: Experiments Workflow Story: Experiments workflow Apr 5, 2021
@shcheklein shcheklein added the priority-p1 Regular product backlog label Apr 5, 2021
@rogermparent
Copy link
Contributor

We should now have all the commands necessary for the first implementation of manipulating local experiments

  • exp run
    • --queue
    • --run-all
    • --reset
  • exp remove
  • exp gc
    • -w
    • -a
    • -T
    • --queued
  • exp apply
  • exp branch
  • exp remove
  • Stop Experiment (not a DVC command, but still a VSCode Command)

From here, we'll want to implement these commands in more friendly places of the UI. All the functionality is in, but different minor changes may be required depending on where in the VSCode UI we stick these commands.

@shcheklein
Copy link
Member Author

@rogermparent excellent, thanks. I'll start reviewing this.

@yalozhkin
Copy link

@mattseddon @rogermparent @shcheklein updated the issue/spec.

@mattseddon
Copy link
Member

@shcheklein I think we can close this one as we are tracking the remaining point under another ticket WDYT?

@shcheklein
Copy link
Member Author

If you don't mind, guys, let's keep it. This is useful for me to track the product progress (by filtering the Story label). It's not precise, but it feels good to keep for me around for now as a reference what has been done there, what else is left.

@mattseddon mattseddon added the A: experiments Area: experiments table webview and everything related label Oct 29, 2021
@mattseddon
Copy link
Member

First iteration done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on priority-p1 Regular product backlog story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc
Projects
None yet
Development

No branches or pull requests

4 participants