Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments: Add an extension Command to stop a running experiment #230

Closed
rogermparent opened this issue Apr 2, 2021 · 0 comments · Fixed by #305
Closed

Experiments: Add an extension Command to stop a running experiment #230

rogermparent opened this issue Apr 2, 2021 · 0 comments · Fixed by #305
Labels
A: extension Area: core extension enhancement New feature or request

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Apr 2, 2021

Currently, we run dvc exp run via IntegratedTerminal, so you can ctrl+c in the Terminal to cancel a running experiment.

This isn't optimal for a few reasons:

  • If we switch away from IntegratedTerminal (which is likely) this will stop working
  • It's just plain unfriendly to users, and we can do better with at least a command

Since we can send text to even the IntegratedTerminal, we should be able to implement a command that sends ^C to the currently tracked terminal and expose a cancel feature to the VSCode command UI.

We'll also need to access this from some points of the UI, and probably the Webview too. #231

I think it would be best to use this Issue to track the command specifically, and then open new specific tickets for the Webview and other UI additions.

@rogermparent rogermparent added enhancement New feature or request vscode labels Apr 2, 2021
@shcheklein shcheklein added A: extension Area: core extension and removed vscode labels Apr 5, 2021
@shcheklein shcheklein changed the title Add a Command to Stop a Running Experiment Experiments: Add an extension Command to stop a running experiment Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: extension Area: core extension enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants