Mock Uri in Jest with vscode-uri
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without using this data in multiple places, the wrapper module didn't serve much purpose and hampered code readability a bit.
mattseddon
reviewed
Apr 6, 2021
mattseddon
reviewed
Apr 7, 2021
Most commands are returned to their original state, proper Uri mocks are kept.
rogermparent
changed the title
Uri in Jest with vscode-uri
rogermparent
commented
Apr 7, 2021
mattseddon
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small slice of the... "ambitious" previous size, which breaks much fewer things.
Effectively it's just the test changes from #218, using the actual
Urilibrary vscode uses in our test mocks. It's not the exact same, but it's the best we're going to get and we can tweak it if needed.This change includes fixes to some of our existing tests that broke since our previous implementation of mocked
Uriwas just a dummy function that returned a string.My intention is to add this one change which we all agree is good, then reimplement the other change we consider good in separating the command definitions out to another file.
Reworking all the commands to use
Configdirectly may still be on the table as we add more and more options, but there's an argument for the shell call commands to have explicit args not tied toConfig. I'll consider this when implementing a solution in a later PR.