Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments: UI for apply, branch, remove an experiment #228

Closed
rogermparent opened this issue Apr 1, 2021 · 7 comments
Closed

Experiments: UI for apply, branch, remove an experiment #228

rogermparent opened this issue Apr 1, 2021 · 7 comments
Assignees
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Apr 1, 2021

Continues from #227

With commands that take Experiments, we'll naturally want to expose UI elements that allow us to run them. One pattern that could handle this group of actions would be a context menu that can be invoked via something like a right click and/or button on each Experiment row.

One implementation that stands out is right-click context menu, which would also work well for adding context menu functionality to any other element in the table, like individual checkpoints. I tested to make sure, and we can listen for right clicks in the webview.


Design proposal

Single row actions preview:
image

Multiple rows actions preview:
image

More details and flows in the Figma spec.

@rogermparent rogermparent added enhancement New feature or request webview 🎨 design Needs design input or is being actively worked on labels Apr 1, 2021
@shcheklein shcheklein changed the title Add UI for Running Commands on Experiments from the Experiments Webview Experiments: UI for apply, branch, remove an experiment Apr 5, 2021
@yalozhkin

This comment has been minimized.

@yalozhkin

This comment has been minimized.

@yalozhkin

This comment has been minimized.

@yalozhkin
Copy link

yalozhkin commented Apr 19, 2021

After researching the multiple selection topic and designing the proposal with the right-click, I thought about using the right-click instead of the icons on hover (but not sure if users get it quickly, need to test).

@mattseddon mattseddon added the A: experiments Area: experiments table webview and everything related label Oct 29, 2021
@mattseddon
Copy link
Member

@rogermparent, covered by #1267?

@rogermparent
Copy link
Contributor Author

I think so, I'll close this and pull some info and screenshots from this Issue's OP into #1267.

@maxagin
Copy link
Contributor

maxagin commented May 22, 2022

Hey folks, while working on #1676 I have used some of the information from #228.

I found a few things that were not clear to me. I left a few questions in the Figma file https://www.figma.com/file/heCQb0FrIfreqn8MsIuV59/Actions-with-Experiments--%E2%80%A2-228 Please let me know wdyt.

@maxagin maxagin self-assigned this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related 🎨 design Needs design input or is being actively worked on enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants