Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an indication of filtering on the Experiment Table webview #1827

Closed
rogermparent opened this issue Jun 2, 2022 · 3 comments
Closed
Assignees
Labels
A: experiments Area: experiments table webview and everything related A: trees Area: SCM and DVC-tracked trees enhancement New feature or request

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Jun 2, 2022

One issue we have in the VSCode extension is the possibility of the user looking at the experients table while unaware of any filters being applied. This is less of an issue with sorts as there's already an indicator, but filters have no feedback on the experiments table itself which becomes an issue when the user isn't currently looking at the dvc sidebar for any reason.

Ideally, we want to show both the fact that filters are applied and the amount of records that are hidden by the filter.

@rogermparent rogermparent changed the title Show filter and sort indicators on the Experiment Table webview Show an indication of filtering on the Experiment Table webview Jun 2, 2022
@mattseddon
Copy link
Member

Couple of things that we are going to do in the short term

  1. Add filtered icon to the column in the table as per screenshot:

Screen Shot 2022-06-02 at 20 15 40

  1. Add a description to the filter by tree which states the number of rows filtered:

image

Both of these items are with @wolmir 👍🏻.

@mattseddon mattseddon added enhancement New feature or request A: experiments Area: experiments table webview and everything related A: trees Area: SCM and DVC-tracked trees labels Jun 3, 2022
@shcheklein
Copy link
Member

Add a description to the filter by tree which states the number of rows filtered:

Can we add it somewhere into the table also please? :)

@rogermparent
Copy link
Contributor Author

Closed by #1872 and #1760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related A: trees Area: SCM and DVC-tracked trees enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants