Add filtered counts to Filter By tree #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -139,4 +143,58 @@ export class ExperimentsFilterByTree | |||
| private getDvcRoots() { | |||
| return this.experiments.getDvcRoots() | |||
| } | |||
|
|
|||
| private updateDescriptionOnChange() { | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
mattseddon
requested review from
sroy3,
rogermparent,
maxagin,
shcheklein and
wolmir
sroy3
approved these changes
Jun 9, 2022
wolmir
approved these changes
Jun 9, 2022
mattseddon
force-pushed
the
add-filter-count
branch
from
300b875 to
8f26e72
Compare
mattseddon
force-pushed
the
add-filter-count
branch
from
8f26e72 to
5cc5966
Compare
|
Code Climate has analyzed commit 5cc5966 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6%. View more on Code Climate. |
mattseddon
added a commit
that referenced
this pull request
Jun 10, 2022
* add filtered counts to the filter by tree description * refactor text collection * add integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1760. The second step for #1827.
This PR adds a description showing the number of filtered experiments and checkpoints to the Filter By tree.
Demo
Screen.Recording.2022-06-09.at.3.37.35.pm.mov