-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plots sections: enable linking in the plots tooltips, other improvements #1933
Comments
|
@jorgeorpinel can you add some more context here, like screenshots, please.
Same, please - more context |
I think @shcheklein meant that instead of tooltips we should have the text visible under each Plot type header |
No, we don't want this text to be permanently visible. Only as (potential) way for placeholders when there are not plots in the section. tooltip should stay as a tooltip but react properly considering that there will be links |
I've updated the description, there was a bug - |
I think I have a good solution for this. I will share the concept soon |
@jorgeorpinel , here is a solution I believe in :) Sharing the example below. Tomorrow I will design the example of a hint including a button (or another link example). Concept: show hint on hover with the mouse over the transparent area so the user can move the cursor into the hint area without it disappearing. When the mouse is out of the hint area - we hide it. This will work also for other similar sections, such as coming errors: DVC errors that may occur during or after running experiment #1636 Example from our favourite GitHub Screen.Recording.2022-06-22.at.10.36.28.PM.mov |
Minor: the hints are not context menus, this is why I suggest we will have them centred in relation to the hovered element. Figma spec. Thanks |
The Figma spec was updated with the new concept. Please let me know if you have any questions or comments. |
This is a transparent area that appears when the icon has hovered. Find more information in the Figma spec We could use a button here, but I think that text link works better for this case. |
Relates to #1954. |
Hey. What is the status of this ticket? Are we all agreed it is ready for development? Thanks |
What are the links we want to put it? Once #2140 is merged, everything is ready to put in links, but I can also add them inside that PR. |
@sroy3 let's wait for iterative/dvc.org#3830 to be merged, @dberenbaum has changed the structure there. We can put those link later, we can create and assign to me a small followup ticket so that we don't block this PR. |
Plots section descriptions.
_Originally posted by @shcheklein in #1922 (review)
The text was updated successfully, but these errors were encountered: