Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots sections: enable linking in the plots tooltips, other improvements #1933

Closed
2 tasks done
jorgeorpinel opened this issue Jun 20, 2022 · 15 comments
Closed
2 tasks done
Assignees
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request priority-p1 Regular product backlog

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 20, 2022

Plots section descriptions.

  • put links to DVC docs in those tooltips, probably means they should toggle by a click / ESC, not disappear
  • keep all three sections visible (for better education(, if section is empty, show the same message instead of it's content

_Originally posted by @shcheklein in #1922 (review)

@jorgeorpinel jorgeorpinel added enhancement New feature or request A: plots Area: plots webview, side panel and everything related labels Jun 20, 2022
@jorgeorpinel
Copy link
Contributor Author

I feel like this repo needs a ux issue label.

@shcheklein shcheklein added the 🎨 design Needs design input or is being actively worked on label Jun 20, 2022
@shcheklein shcheklein changed the title components: make Plots dashboard tooltips into subtitles, enable linking components: enable linking in the plots tooltips, other improvements to Plot sections Jun 20, 2022
@shcheklein shcheklein changed the title components: enable linking in the plots tooltips, other improvements to Plot sections Plots sections: enable linking in the plots tooltips, other improvements Jun 20, 2022
@maxagin
Copy link
Contributor

maxagin commented Jun 21, 2022

put links to DVC docs in those tooltips

@jorgeorpinel can you add some more context here, like screenshots, please.

keep all three sections visible

Same, please - more context

@jorgeorpinel
Copy link
Contributor Author

I think @shcheklein meant that instead of tooltips we should have the text visible under each Plot type header

image

@maxagin
Copy link
Contributor

maxagin commented Jun 21, 2022

We had it before. I just want to understand what is the reason for changing as it makes sense if the description is dynamic. Please clarify it for me. Thanks

Screen Shot 2022-06-21 at 4 22 44 PM

@shcheklein
Copy link
Member

I think @shcheklein meant that instead of tooltips we should have the text visible under each Plot type header

No, we don't want this text to be permanently visible. Only as (potential) way for placeholders when there are not plots in the section.

tooltip should stay as a tooltip but react properly considering that there will be links

@shcheklein
Copy link
Member

I've updated the description, there was a bug - should not toggle -> should toggle

@maxagin
Copy link
Contributor

maxagin commented Jun 22, 2022

I think I have a good solution for this. I will share the concept soon

@maxagin
Copy link
Contributor

maxagin commented Jun 23, 2022

@jorgeorpinel , here is a solution I believe in :) Sharing the example below. Tomorrow I will design the example of a hint including a button (or another link example).

Concept: show hint on hover with the mouse over the transparent area so the user can move the cursor into the hint area without it disappearing. When the mouse is out of the hint area - we hide it.

This will work also for other similar sections, such as coming errors: DVC errors that may occur during or after running experiment #1636

Example from our favourite GitHub

Screen.Recording.2022-06-22.at.10.36.28.PM.mov

@maxagin
Copy link
Contributor

maxagin commented Jun 23, 2022

Minor: the hints are not context menus, this is why I suggest we will have them centred in relation to the hovered element. Figma spec. Thanks

@maxagin
Copy link
Contributor

maxagin commented Jun 23, 2022

The Figma spec was updated with the new concept. Please let me know if you have any questions or comments.

@maxagin
Copy link
Contributor

maxagin commented Jun 23, 2022

This is a transparent area that appears when the icon has hovered. Find more information in the Figma spec

We could use a button here, but I think that text link works better for this case.

Screen Shot 2022-06-23 at 2 42 30 PM

@mattseddon
Copy link
Member

Relates to #1954.

@maxagin
Copy link
Contributor

maxagin commented Jul 25, 2022

Hey. What is the status of this ticket? Are we all agreed it is ready for development? Thanks

@shcheklein shcheklein added the priority-p1 Regular product backlog label Jul 25, 2022
@mattseddon mattseddon removed the 🎨 design Needs design input or is being actively worked on label Aug 2, 2022
@sroy3
Copy link
Contributor

sroy3 commented Aug 3, 2022

What are the links we want to put it? Once #2140 is merged, everything is ready to put in links, but I can also add them inside that PR.

@shcheklein
Copy link
Member

@sroy3 let's wait for iterative/dvc.org#3830 to be merged, @dberenbaum has changed the structure there. We can put those link later, we can create and assign to me a small followup ticket so that we don't block this PR.

@sroy3 sroy3 closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request priority-p1 Regular product backlog
Projects
None yet
Development

No branches or pull requests

5 participants