Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in section description tooltips #2140

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Links in section description tooltips #2140

merged 5 commits into from
Aug 4, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Aug 3, 2022

Part of #1933

This is an example with a link (this link is not in the actual code, links will need to be provided later)

Screen.Recording.2022-08-03.at.2.22.05.PM.mov

@sroy3 sroy3 added the product PR that affects product label Aug 3, 2022
@sroy3 sroy3 self-assigned this Aug 3, 2022
@sroy3 sroy3 marked this pull request as ready for review August 3, 2022 18:53
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI tests are failing, but is that unrelated to the PR?

demo/dvc.lock Outdated Show resolved Hide resolved
@sroy3 sroy3 requested a review from shcheklein August 3, 2022 20:05
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2022

Code Climate has analyzed commit 879fdb6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon
Copy link
Member

I'll ask Jorge what he had in mind when I talk to him today.

@sroy3 sroy3 merged commit eaed465 into main Aug 4, 2022
@sroy3 sroy3 deleted the tooltip-links branch August 4, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants