-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for sections with the copy button #2040
Comments
We can't I think, or we would have to make the delay 0, or show them on click on the cell.
this is done, I think?
Seems super minor, any specific concerns about this? |
Hover with delay 0 or 0.5. This is something we better do for any tooltips I think!
Yes
It is minor, but still an improvement I think. When you move the mouse (table view), which changes the appearance of the cursor all the time, it is annoying |
No, we can't I think. It will become extremely reactive (imagine tips floating after your mouse pointer)
let's remove the checkbox?
Looks like I misunderstood what you actually suggest then. Could you clarify please? |
I can see the existing copy button being considered clunky, but that doesn't necessarily mean the tooltip is the best place to put the button. I think adding "Copy Cell" to the webview context menu would be a very strong, if not the best solution since we already have that pattern of user action established. It'll involve making the context menu recognize cell as well as row, but I'd bet we're probably going to end up doing it for some feature at some point regardless. |
Yes, right click can be a fine compromise to make all the content less jumpy. |
I would expect the copy button to be placed beside the full value, which is the tooltip.
Great idea - adding the "Copy value" also to the context menu! Thank you. Adding it to the TODO @shcheklein, the description was updated. Do you think we can move forward with the development? |
A few comments.
otherwise it's fine to me |
"double clicked" is good but not obvious, or I am wrong? I would keep the copy button in the tooltip. WDYT? |
I would suggest placing it at the top/right (-40%) corner. WDYT? |
dunno, good to check, but double click to select something is very basic, OS level operation btw, I would still support double click on the cell - do not select text, but copy its full value into buffer
I don't know tbh, any examples (Airtable, Notion, etc?) |
Sure, but the fact that I am selecting an unknown number, is confusing me. Not sure.
I do not think we would like to change what we currently have, but just improve. No? |
it's not unknown (yes the value is cut, but that it's not unknown). You are not selecting, you are copying the value in the buffer. Idea here - the more things that are expected to work (even for some people) would work is better. It's quite annoying in any of the interfaces when double click to select is broken (usually would select some extra word, or icon), or click + keep + select (via hover) is broken (no matter how you hover it doesn't select an email), etc. We should be paying attention to these very fundamental micro interactions. And there should be a very strong reason to break them. In this case. We can't let select the value directly (since it's not an actual value)? Arguably this is correct (still though not 100% clear), but can we at least make double click work (no selection appear but we can blink a tip that actual value now in the buffer).
That question was specifically about which corner to pick and what margin to use (-40, -60, etc). |
We will allow double-clicking on the cell value. Then the user will be able to copy the value using a keyboard shortcut or content menu.
@shcheklein here is an example I had in mind: |
@shcheklein I have read a few articles about the table today and found this example by accident. However, as we have discussed this ticket will be taken care of a bit later. |
Closing this as a low priority for now |
TODO
The text was updated successfully, but these errors were encountered: