Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the exp name just by clicking on the name in column #2055

Closed
maxagin opened this issue Jul 18, 2022 · 13 comments
Closed

Change the exp name just by clicking on the name in column #2055

maxagin opened this issue Jul 18, 2022 · 13 comments
Labels
A: experiments Area: experiments table webview and everything related DVC-first Needs to be done first for DVC enhancement New feature or request

Comments

@maxagin
Copy link
Contributor

maxagin commented Jul 18, 2022

This is a kinda fast way to help users to have custom information about the experiment. Please let’s discuss this idea. Thanks

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

@maxagin maxagin added discussion A: experiments Area: experiments table webview and everything related labels Jul 18, 2022
@shcheklein
Copy link
Member

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

@shcheklein
Copy link
Member

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

Not a big fan of this, since circles are too small. So if we do this - it will be a trade off.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

Note: we finally will remove the plots toggle on the name and will use just a circle to toggle plots.

Not a big fan of this, since circles are too small. So if we do this - it will be a trade off.

I really hope we will be able to move forward with the standard eye concept. Which to my mind is the most user-friendly solution.

@shcheklein
Copy link
Member

to move forward with the standard eye concept.

yes, it's not that easy to implement + it will be taking even more space (eyes, checkboxes, stars) + you are biased a bit - when I talk to people who do not come from design that sometimes are not that familia with this concept

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

when I talk to people who do not come from design that sometimes are not that familia with this concept

I am parry:

Screen Shot 2022-07-18 at 8 27 58 PM

The icons width 18x18px. It looks very compact I think.

Screen Shot 2022-07-18 at 8 30 09 PM

@shcheklein
Copy link
Member

@maxagin trust me, I've seen this :) And trust me I still had some feedback that an eye icon is not that clear.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

Good @shcheklein . We are going to make sure to guide the user ("Explain that circle triggering plots"), even using current circles. The same will work for the eye (if we will decide to have it). So I think that the icon is less important.

Regarding the:

The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla

We could hide the name without modifying it, and display a sort of "description" field visually same as the title. Keeping always the DVC name + a new editable field. Just thinking in loud. WDYT?

@shcheklein
Copy link
Member

We should try to avoid having too different layouts / names between the extension and the dvc exp show. If I see the names I kinda expect to have them in CLI as well.

@maxagin
Copy link
Contributor Author

maxagin commented Jul 19, 2022

If I see the names I kinda expect to have them in CLI as well.

Sure. EXP description - a new field for CLI. It is just for GUI will appear instead of the title. WDYT?

Sorry, it is my bad. I hope we will have the description one day, so it is better to change the name of the exp I think.

@shcheklein
Copy link
Member

Sure. EXP description - a new field for CLI.

I'm not sure I understand this tbh.

@dberenbaum
Copy link
Contributor

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

There's no existing command (see iterative/dvc#6667), but I think it would be helpful, and I doubt it's hard to implement since it should be possible by adding/removing git refs. cc @karajan1001

@maxagin maxagin added enhancement New feature or request and removed discussion labels Jul 19, 2022
@karajan1001
Copy link

Good idea. The problem is that names are provided and stored in DVC. @dberenbaum @pmrowla is there a way to change them after / where do we store them now?

There's no existing command (see iterative/dvc#6667), but I think it would be helpful, and I doubt it's hard to implement since it should be possible by adding/removing git refs. cc @karajan1001

I think it's not very hard to implement, but still need some time to finish it.

@maxagin maxagin added the DVC-first Needs to be done first for DVC label Jul 21, 2022
@shcheklein
Copy link
Member

Closing this in favor of #2457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related DVC-first Needs to be done first for DVC enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants