Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: Help navigate in a lot of experiments #1720

Closed
2 of 6 tasks
maxagin opened this issue May 16, 2022 · 23 comments
Closed
2 of 6 tasks

Story: Help navigate in a lot of experiments #1720

maxagin opened this issue May 16, 2022 · 23 comments
Labels
🎨 design Needs design input or is being actively worked on discussion 📦 product Needs product input or is being actively worked on story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc

Comments

@maxagin
Copy link
Contributor

maxagin commented May 16, 2022

These comments are the only meaningful thing left in this ticket

image


outdated:

This epic is created so we can discuss the concepts together with the DVC team.

Ideas

Figma specs

@maxagin maxagin self-assigned this May 16, 2022
@maxagin maxagin mentioned this issue May 16, 2022
6 tasks
@maxagin maxagin added the 🎨 design Needs design input or is being actively worked on label May 16, 2022
@shcheklein shcheklein added the story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc label May 16, 2022
@shcheklein shcheklein changed the title Help navigate in a lot of experiments Story: help navigate in a lot of experiments May 16, 2022
@shcheklein shcheklein added the product PR that affects product label May 16, 2022
@shcheklein shcheklein changed the title Story: help navigate in a lot of experiments Story: Help navigate in a lot of experiments May 16, 2022
@shcheklein

This comment was marked as off-topic.

@shcheklein

This comment was marked as off-topic.

@maxagin

This comment was marked as off-topic.

@shcheklein

This comment was marked as off-topic.

@maxagin

This comment was marked as off-topic.

@maxagin

This comment was marked as off-topic.

@shcheklein

This comment was marked as off-topic.

@maxagin

This comment was marked as off-topic.

@maxagin maxagin removed their assignment May 20, 2022
@maxagin
Copy link
Contributor Author

maxagin commented May 20, 2022

Discussion between Ivan and Dave

[shcheklein]
Question to answer first here - do we need this on the DVC end. And we need to brainstorm a bit on different possible UX flows that would achieve the same result - easier to navigate.

[dberenbaum]
What is the primary use case this intends to target? Is it about having some consistent baseline that you want to save and always compare against? Is it about being able to lock an experiment or two to the top of the table temporarily to see how they stack up against others?

[shcheklein]
When I was iterating on get started repo recently I got lost quickly with all the combinations. Partially the reason was that I was changing datasets (and then rerunning the same set of experiments) and we don't show data. But also since dataset name is the same, size in that case was not signaling to me much, etc. Pretty much at some points in the process I felt that I had "good enough" iterations that I can get back if there are no luck with further improvements, but it was impossible to put some label, pin, group, save filter, etc.

To some extent experiment names solve this, but it means you have to think in advance and name each experiment appropriately - it creates a burden by itself.

[dberenbaum]

To some extent experiment names solve this, but it means you have to think in advance and name each experiment appropriately - it creates a burden by itself.

Would naming/renaming experiments after execution help?

In VS Code, it might also make sense to pin experiments in some way to always show them at the top. To me, those types of features might make more sense in VS Code first since it's harder for me to imagine how to make them convenient enough in dvc exp show to be worthwhile. What do you think?

[shcheklein]

Would naming/renaming experiments after execution help?

yep, partially. I would prefer to have some pins/groups/free text form notes about experiments though.

What do you think?

good question. I can tell that CLI is also quite unusable though in such scenarios ... not sure if we want to go very far, but may be at least pin / label experiments in some way?

@maxagin
Copy link
Contributor Author

maxagin commented May 24, 2022

Figma specs - Star experiments in table (Phase 1)

@maxagin
Copy link
Contributor Author

maxagin commented Jul 5, 2022

Labels (using GH colour scheme), just so we can keep this ticket alive. Would probably make sense to sort by label, the same way we are planning to show only starred expS.

Screen Shot 2022-07-04 at 8 19 01 PM

@maxagin
Copy link
Contributor Author

maxagin commented Jul 18, 2022

Hey @shcheklein . As a part of the task "Help navigate in a lot of experiments" I think that being able to fold not interesting EXPs can be useful. Please let me know WDYT.
Concept on Figma

@maxagin
Copy link
Contributor Author

maxagin commented Jul 18, 2022

@shcheklein here is another concept I would like to share in relation to this ticket: "Group interesting runs in sections with the title"
Figma

@mattseddon mattseddon added 📦 product Needs product input or is being actively worked on and removed status: 🎨 design-in-progress product PR that affects product labels Aug 5, 2022
@maxagin
Copy link
Contributor Author

maxagin commented Sep 2, 2022

@mattseddon What do we need to unlock this: Naming/renaming experiments after execution?

@mattseddon
Copy link
Member

@mattseddon What do we need to unlock this: Naming/renaming experiments after execution?

I believe the ticket for that is #2055

IMO this ticket needs user input and product decisions.

Hard to know what the next steps are from the OP.

@maxagin
Copy link
Contributor Author

maxagin commented Sep 2, 2022

@mattseddon What do we need to unlock this: Naming/renaming experiments after execution?

I believe the ticket for that is #2055

Yeah. My question was: How to unlock it?
From #2055 "I think it's not very hard to implement, but still need some time to finish it."

@maxagin
Copy link
Contributor Author

maxagin commented Sep 2, 2022

IMO this ticket needs user input and product decisions.

Yes, but it has directions, so I would keep it alive.

@mattseddon
Copy link
Member

Yeah. My question was: How to unlock it?

First, we need to decide how high of a priority this is for us. We then need to convey that priority to the DVC team so that they can schedule the work... or not.

@shcheklein
Copy link
Member

Let's keep it and get back when we have a bit more user input + we are done with the current activities. I'd like to keep it lightweight as much as possible. It would be a mistake to implement something complicated like labels. On the other hand, we naming + some lightweight notes/comments could be done I think. Anyways, let's not prioritize for now.

@dberenbaum
Copy link
Contributor

My feedback on the experiments table:

  • It's not clear which experiments and commits are being shown (or even the relationship between experiments and commits). TBH I'm not sure what's being shown here now so don't know what to suggest 🤔 .
  • Sorting and filtering across commits would be helpful (also true for CLI). It's not clear why certain experiments get sorted/filtered and others do not, and it's not helpful to only be able to sort within a commit. Maybe it makes sense to be able to toggle between a Git history view like we have now and more of a flat table view that treats all experiment runs/commits equally?
  • Commits without any metrics should probably be hidden/deemphasized.
  • What about using the exp show options for filtering the rows to show? It would be more consistent across interfaces and increase flexibility.

@dberenbaum
Copy link
Contributor

dberenbaum commented Nov 5, 2022

Also this is mentioned in #2726, but I would find renaming (as suggested above) helpful. If it's decided it's worth pursuing, we can look into it on the DVC side.

Edit: I think this is a bit different than #2457. No matter what, auto naming is probably not going to be what I would name them manually, and often I don't even know ahead of time what I should name them since my experiments space grows over time and I need to find new ways to differentiate them. Tagging is another useful option here.

@alex000kim
Copy link

Modifying the table view to only show differences (vs all available parameters) would help navigate a table with lots of experiments.

@mattseddon
Copy link
Member

Closing in favour #1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on discussion 📦 product Needs product input or is being actively worked on story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc
Projects
None yet
Development

No branches or pull requests

5 participants