Add shortcut to filter experiments to starred #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ee617eb and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.2% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
mattseddon
commented
Aug 10, 2022
| ) | ||
|
|
||
| expect(mockAddFilter).to.be.calledWith(starredFilter) | ||
| }).timeout(WEBVIEW_TEST_TIMEOUT) |
This was referenced Aug 10, 2022
|
Related to #1720 |
|
If we merge this one I'll use it in a product update video. |
sroy3
approved these changes
Aug 10, 2022
julieg18
approved these changes
Aug 10, 2022
mattseddon
force-pushed
the
sort-by-starred
branch
from
fa9e2b0 to
c76f95f
Compare
mattseddon
force-pushed
the
add-filter-to-starred
branch
from
6b08d17 to
1603cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/4
main<- #2164 <- #2169 <- this <- #2171This PR adds a command to the palette and the experiments filter by tree view/title which will add the starred filter to the table filters.
Demo
Screen.Recording.2022-08-10.at.1.32.10.pm.mov