Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-root-workspaces do not work #2673

Closed
alkatar21 opened this issue Oct 25, 2022 · 7 comments · Fixed by #2795
Closed

Multi-root-workspaces do not work #2673

alkatar21 opened this issue Oct 25, 2022 · 7 comments · Fixed by #2795
Assignees
Labels
A: integration Area: DVC integration layer priority-p1 Regular product backlog triage

Comments

@alkatar21
Copy link

dvc: 2.30.1
dvc VS-Code extension: v0.5.7

I am using a multi-root workspace and dvc works as expected on the console.

But the tracked data is not shown in the Explorer under DVC Tracked. There are also no changes shown in the Source Control tab and the extension tab is loading all the time after visiting the tab once:
grafik

The output window shows the following:

[version: 0.5.7, ...] > /bin/python3 -m dvc root - INITIALIZED
[version: 0.5.7, ...] > /bin/python3 -m dvc --version - INITIALIZED
[version: 0.5.7, ...] > /bin/python3 -m dvc --version - COMPLETED (312ms)
[version: 0.5.7, ...] > /bin/python3 -m dvc root - FAILED with code 253 (443ms)
�[31mERROR�[39m: you are not inside of a DVC repository (checked up to mount point '/workspaces/<project>')

If I remove all other folders and only keep the one wich uses DVC and reloed the window everything works as expected.
If I add the folders again now, the extension still works as expected and simply adds the Project folder as additional hierarchy to the DVC Tracked window.
If I know reload the window everything is again like in the beginning and the extension does not work.

@shcheklein shcheklein added A: integration Area: DVC integration layer priority-p1 Regular product backlog triage labels Oct 26, 2022
@shcheklein shcheklein changed the title multi-root-workspaces do not work Multi-root-workspaces do not work Oct 26, 2022
@sroy3 sroy3 self-assigned this Nov 2, 2022
@sroy3
Copy link
Contributor

sroy3 commented Nov 14, 2022

@alkatar21 just to make sure I can reproduce things on my side correctly, how is you workspace built at the moment? Are the folders in the workspace all under the same folder and one of these folders is a DVC project? Or is it a custom workspace (saved as a file) with multiple folders added to it (folders that aren't all necessarily under the same folder)? Thanks.

@alkatar21
Copy link
Author

@sroy3 I'm not sure I understand it correctly. It's a workspace that VSCode calls Multi-root-workspaces. So yes, there is an extra VS-Code file that organizes which folders are present. Does that help?

And here is the official source for extension authors with another link with a link to more docs about the API: https://code.visualstudio.com/docs/editor/multi-root-workspaces#_extensions

@sroy3
Copy link
Contributor

sroy3 commented Nov 14, 2022

@alkatar21 thanks it does help. Sorry I didn't know VS Code had an official name for this.

@alkatar21
Copy link
Author

Another observation I just made:
I am working in a Docker dev container where DVC is installed. When I rebuild the container with Rebuild Container DVC works. But as soon as I restart VS-Code either with Developer: Reload Window or by restarting the application it does not work as described in the issue.

So it really seems to be just a bug during startup, where the extension does not startup fully.

@alkatar21
Copy link
Author

This does now work as expected with v0.5.14. DVC TRACKED and Source Controll work as expected. Thanks 👍

Since the PR mentions that other things I don't use also don't work, presumably the ticket should still remain open?

@sroy3
Copy link
Contributor

sroy3 commented Nov 18, 2022

This does now work as expected with v0.5.14. DVC TRACKED and Source Controll work as expected. Thanks 👍

Since the PR mentions that other things I don't use also don't work, presumably the ticket should still remain open?

Thanks for the quick feedback.

Yes, let's leave this open until I make sure that every other feature still works

@sroy3
Copy link
Contributor

sroy3 commented Nov 18, 2022

I think I found all of the places that could be affected by the multi root, but if you ever stumble on anything else, don't hesitate to raise an issue. Thank you for raising this issue, it's great to have users share different ways to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: integration Area: DVC integration layer priority-p1 Regular product backlog triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants