Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check availability and compatibility on DVC projects in multi root workspaces #2795

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Nov 18, 2022

Closes #2673. This check on the Python path and DVC path of the first root with a DVC project (if there is one) instead of just looking at the first folder.

@sroy3 sroy3 added the bug Something isn't working label Nov 18, 2022
@sroy3 sroy3 self-assigned this Nov 18, 2022
@sroy3 sroy3 marked this pull request as ready for review November 18, 2022 18:17
@codeclimate
Copy link

codeclimate bot commented Nov 18, 2022

Code Climate has analyzed commit 9a0e534 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 9a95426 into main Nov 18, 2022
@sroy3 sroy3 deleted the check-project-folder branch November 18, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-root-workspaces do not work
2 participants