Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiple commits feature #3036

Closed
6 tasks done
julieg18 opened this issue Jan 2, 2023 · 4 comments
Closed
6 tasks done

Improve multiple commits feature #3036

julieg18 opened this issue Jan 2, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request priority-p1 Regular product backlog research

Comments

@julieg18
Copy link
Contributor

julieg18 commented Jan 2, 2023

Followup to #3016

@julieg18 julieg18 added enhancement New feature or request priority-p1 Regular product backlog research labels Jan 2, 2023
@julieg18 julieg18 self-assigned this Jan 2, 2023
@julieg18 julieg18 added the bug Something isn't working label Jan 3, 2023
@julieg18
Copy link
Contributor Author

julieg18 commented Jan 5, 2023

Make split between the "main" row and "past commit" rows more obvious

Looked into some other tables but had some difficulty finding ideas since no table that I had a clear "split" between rows minus when the rows were in collapsible groups. But here's one idea I experimented with:

Screenshot 2023-01-05 at 8 17 01 AM

Though it's hard for me to tell when something looks good or I've been staring at it for too long 😅 Any other ideas that we want to test out? cc @iterative/vs-code, @shcheklein

@julieg18 julieg18 removed the bug Something isn't working label Jan 5, 2023
@shcheklein
Copy link
Member

@julieg18 I like it! it's simple and explicit. We'll be able to add a dropdown of some other element to configure which commits to show as a next step, it's an obvious and good place for that.

I don't think we need ":"

@julieg18
Copy link
Contributor Author

Two design ideas so far for commit tooltips on the experiment table!

Screenshot 2023-01-13 at 11 49 16 AM

Screenshot 2023-01-13 at 11 58 00 AM

Any preference or other ideas/inspiration? cc @iterative/vs-code, @shcheklein

@shcheklein
Copy link
Member

I think the first one is better! I can't make screenshot (it doesn't allow me for whatever reason), but take a look at how GitLens represents them in the COMMITS side panel. We can do something similar (simplify if some parts there take more than 10 minutes to implement :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-p1 Regular product backlog research
Projects
None yet
Development

No branches or pull requests

2 participants