Add git-commit icon to experiments table and quick pick
#3124
Conversation
| @@ -3,6 +3,8 @@ import { VSCodeTag } from '@vscode/webview-ui-toolkit/react' | |||
| import { CommitData } from 'dvc/src/experiments/webview/contract' | |||
| import styles from './styles.module.scss' | |||
| import Tooltip from '../../../shared/components/tooltip/Tooltip' | |||
| import { Icon } from '../../../shared/components/Icon' | |||
| import { GitCommit } from '../../../shared/components/icons' | |||
There was a problem hiding this comment.
I looked into add the git-commit icon to the experiments tree view but I couldn't find a way add icons to TreeItem descriptions
| @@ -42,7 +42,9 @@ const getItemWithDescription = ( | |||
| ) => { | |||
| const item = getItem(experiment, firstThreeColumnOrder) | |||
| if (!experiment.checkpoints && experiment.displayNameOrParent) { | |||
| item.description = experiment.displayNameOrParent | |||
| item.description = `${experiment.commit ? '$(git-commit)' : ''}${ | |||
There was a problem hiding this comment.
I wasn't sure if the quick pick looked better or worse with the git-commit icons:
What does everyone else think?
There was a problem hiding this comment.
Do we have control over the size? If not I prefer the second one, else if we can make the icon a little smaller it could look good.
There was a problem hiding this comment.
Do we have control over the size? If not I prefer the second one, else if we can make the icon a little smaller it could look good.
Nope, only one size option :(
julieg18
changed the title
git-commit icon to experiments tablegit-commit icon to experiments table and quick pick
|
Code Climate has analyzed commit 4dd76eb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
Adds the
git-commiticon to the experiment table secondary name commit messages/tooltips and experiment selection quick picksDemo
Screen.Recording.2023-01-19.at.7.47.40.AM.mov
Part of #3036