Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a way to see information about an experiment (or many?) by hovering / clicking on them #4229

Closed
shcheklein opened this issue Jul 6, 2023 · 13 comments
Assignees
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request priority-p1 Regular product backlog story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc

Comments

@shcheklein
Copy link
Member

Based on user feedback. If there are two many parameters, table becomes too long and it's hard to navigate it. It's a usual story for a repo like YOLO.

We need a way for users to be able to see a preview of an experiment, or some summary etc.

It reminds me the compare panel in Studio (table pivot), we can take that an idea (multiple experiments, pivot, highlight differences, etc), but we need a better UX for that + I think we can do better tooltips, etc.

As an idea for UX - can we use the preview panel in VS Code for this? (besides tooltips).

@shcheklein shcheklein added A: experiments Area: experiments table webview and everything related product PR that affects product story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc enhancement New feature or request priority-p1 Regular product backlog and removed product PR that affects product A: experiments Area: experiments table webview and everything related labels Jul 6, 2023
@mattseddon
Copy link
Member

I think that some way of moving columns/groups of columns to the left of the table might be low-hanging fruit. I think we also need a way to make this quick pick more obvious/get people to use it:

image

We could expand on the "leaderboard" idea/usage from #4269 and show a condensed version of the table that can be sorted by not only columns but a formula. We would have to limit the number of columns that can be shown to < 20 or users would run into the same issue. The main difference would be that records would be shown outside of the usual commit/experiment hierarchy.

#1994 would also be a potential solution for this issue (or at least help with the problem).

@mattseddon mattseddon changed the title Have a way to see information about an experiment (or many?) but hovering / clicking on them Have a way to see information about an experiment (or many?) by hovering / clicking on them Jul 18, 2023
@shcheklein shcheklein self-assigned this Jul 18, 2023
@shcheklein
Copy link
Member Author

  • Followup if user was aware about DnD cc @shcheklein
  • Check other trackers - how do they show / do they show this information?

@shcheklein
Copy link
Member Author

DnD - yes, it was known. It doesn't solve the issue. What is needed is a side panel (like in MD preview) that could be open and update when we select experiments.

@mattseddon
Copy link
Member

mattseddon commented Jul 31, 2023

As discussed in last week's planning meeting. We could add another tree view which shows "focused" experiments transposed. Here is a screenshot with a prototype view moved to the "secondary sidebar":

image

It should be noted that these views can be searched/filtered for/to specific values:

Screen.Recording.2023-07-31.at.11.51.37.am.mov

Please note: There was no polishing involved in the above prototype, I wanted to show the idea only (e.g I joined the param/metric key/value with an = without giving it a second thought)

@shcheklein
Copy link
Member Author

@mattseddon thanks! Can it be open / close automatically or on a button click on the "right" side (similar to MD previews)?

@mattseddon
Copy link
Member

Yes, we can open. No, we cannot close. I cannot find a way to programmatically move a view to the secondary sidebar and we cannot contribute a view directly to the secondary sidebar:

image

@shcheklein
Copy link
Member Author

Yes, we can open. No, we cannot close. I cannot find a way to programmatically move a view to the secondary sidebar and we cannot contribute a view directly to the secondary sidebar:

means probably that if someone would switch to their code they would still see that sidebar?

(if it's significantly easy to implement - let's go for it, otherwise feels like a suboptimal UX tbh)

@mattseddon
Copy link
Member

There are hotkeys to open/close the sidebars but still up to the user what they want to do.

Screen.Recording.2023-07-31.at.12.58.42.pm.mov

Markdown preview also does not close itself when the focus is taken away.

I am not advocating for this solution but there will be limitations with whatever gets put in.

@mattseddon
Copy link
Member

mattseddon commented Jul 31, 2023

We could try and squeeze as much information as possible into the tooltip. The drawbacks of this are that there isn't much space, the tooltip cannot be interacted with and it is not obvious that the functionality might be there:

image

That is also the max size of the tooltip.

@mattseddon
Copy link
Member

mattseddon commented Jul 31, 2023

@mattseddon
Copy link
Member

mattseddon commented Aug 2, 2023

DnD - yes, it was known. It doesn't solve the issue. What is needed is a side panel (like in MD preview) that could be open and update when we select experiments.

@shcheklein can you please ask the user about "Move to Start" as well.

@mattseddon
Copy link
Member

and show only changed.

@shcheklein
Copy link
Member Author

Closing this for now, we'll come to the proper side panel implementation a bit later. For now there is a workaround with moving things to the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request priority-p1 Regular product backlog story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc
Projects
None yet
Development

No branches or pull requests

2 participants