Drag and drop placeholder position #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
commented
Apr 8, 2022
| export const dragAndDrop = ( | ||
| startingNode: HTMLElement, | ||
| endingNode: HTMLElement | ||
| export const dragEnter = ( |
There was a problem hiding this comment.
Sorry about the messed up diff here. I changed the order of the two functions because dragAndDrop calls dragEnter and it made more sense for it to come before.
…terative/vscode-dvc into drag-drop-placeholder-position
|
Code Climate has analyzed commit ef1f20a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.5% (0.0% change). View more on Code Climate. |
mattseddon
approved these changes
Apr 10, 2022
|
Caused by this test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-04-08.at.3.10.16.PM.mov
Now I need to fix the comparison table before merging this as it is now broken.I let the comparison table behaviour the same as it was. It's the next item on my list.