Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a border to the pinned column #1601

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Add a border to the pinned column #1601

merged 3 commits into from
Apr 22, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Apr 21, 2022 •
edited
Loading

Part of #1565
Screen Shot 2022-04-21 at 10 34 14 AM
Screen Shot 2022-04-21 at 10 46 30 AM

@sroy3 sroy3 self-assigned this Apr 21, 2022
@sroy3 sroy3 marked this pull request as ready for review April 21, 2022 15:11
rogermparent
rogermparent approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we don't have a Story for pinned columns that Chromatic can run against, otherwise it'd be caught here. Not a huge deal, but maybe something we want in the future.

@sroy3
Copy link
Contributor Author

sroy3 commented Apr 21, 2022

I'll add a story that's a good point

@sroy3
Copy link
Contributor Author

sroy3 commented Apr 22, 2022

I had to add a way to set an initial pinned column for the story. I was against it at first (adding code for Storybook only), but we might want to keep it in the state eventually so I guess it's fine.

@sroy3 sroy3 enabled auto-merge (squash) April 22, 2022 13:24
@codeclimate
Copy link

codeclimate bot commented Apr 22, 2022

Code Climate has analyzed commit 3736f29 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit f0baa24 into main Apr 22, 2022
@sroy3 sroy3 deleted the pinned-column-border branch April 22, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent approved these changes

@mattseddon mattseddon mattseddon approved these changes

@wolmir wolmir Awaiting requested review from wolmir

Assignees

@sroy3 sroy3

Labels
🏠 housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sroy3 @rogermparent @mattseddon