Mark files in deleted diff and not in cache status as not in cache #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| this.pathInSet(path, modifiedAgainstCache) | ||
| ), | ||
| ...modifiedAgainstCache | ||
| ]) | ||
| } | ||
|
|
||
| private setModifiedAndNotInCache( | ||
| private setComplexStatuses( |
There was a problem hiding this comment.
Function setComplexStatuses has 31 lines of code (exceeds 30 allowed). Consider refactoring.
mattseddon
commented
May 4, 2022
| @@ -371,5 +371,187 @@ describe('RepositoryState', () => { | |||
| untracked: emptySet | |||
| }) | |||
| }) | |||
|
|
|||
| it('should display all tracked paths as not in cache when the project is first opened (before pull)', () => { | |||
| const diff = { | |||
There was a problem hiding this comment.
[F] This is the data provided from our demo project when it is in the state shown in the screenshots
sroy3
approved these changes
May 4, 2022
rogermparent
approved these changes
May 4, 2022
|
Code Climate has analyzed commit da51c1e and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1646.
Screenshots (project in same state as issue)
Note: For the time being I have left the children of "not in cache" folders undecorated as the data provided is not granular enough. This should be solved by the new dvc data:status command's output (and our subsequent rewrite of this subsystem):