Webview design cleanup #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,7 @@ | |||
| * { | |||
| box-sizing: border-box; | |||
| outline: none; | |||
| font-family: 'monospace', 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif; | |||
There was a problem hiding this comment.
We'll probably want to use some of the VSCode-injected CSS variables like --vscode-font-family, --vscode-font-weight, and --vscode-editor-font-family so we use the user's configured fonts- doing so allows us to integrate our webviews with the user's VSCode and take advantage of the fonts provided to us as a free resource.
I'm thinking since the --vscode-font-family is generally sans serif and --vscode-editor-font-family monospace, we can use the former for UI elements and the latter for the table.
This concern relates to #175 as well.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦢 🎵
Just a few tweaks to ui