Rearrange internals of base workspace webviews #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
May 13, 2022
| @@ -255,14 +246,6 @@ export class WorkspaceExperiments extends BaseWorkspaceWebviews< | |||
| return this.runCommand(commandId, cwd, experiment.name) | |||
| } | |||
|
|
|||
| private async getDvcRoot(overrideRoot?: string) { | |||
There was a problem hiding this comment.
[F] In #1701 we need this property to be in both classes derived from BaseWorkspaceWebviews
mattseddon
commented
May 13, 2022
| import { WorkspacePlots } from '../workspace' | ||
|
|
||
| export const registerPlotsCommands = (plots: WorkspacePlots) => { | ||
| commands.registerCommand(RegisteredCommands.PLOTS_SHOW, () => { |
There was a problem hiding this comment.
[F] Having this registered in this way means we have no telemetry events for it so far 🤦🏻 .
|
Code Climate has analyzed commit 8230d59 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 72.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
|
Overall coverage from the two PRs is |
sroy3
approved these changes
May 13, 2022
rogermparent
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main<- this <- #1701Noticed this misalignment whilst working on #1701. Pulled it out to make it easier to review.