Prevent infinite loop when trying to open plots #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
approved these changes
May 17, 2022
|
Code Climate has analyzed commit e433bed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1670 & #1649
Previously when an experiment was missing from the returned
plots diffoutput we would continue to try and fetch it until such time that either 1. it was magically found or 2. the user's machine blew up.We now mark the experiment as "fetched" but will try to get that revision again every time that either the file watcher is triggered or new revisions need to be fetched until such time that the user unselects the experiment.
This will tie in with the design from #1649. We will be able to show that the revision does not contain all data in the top section of the webview. The user can then decide to manually retry or drop the revision from the view.